Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use highlight default for DEFAULT_DEFS #2636

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

kevmuko
Copy link
Contributor

@kevmuko kevmuko commented Jan 20, 2024

In the previous colors.setup() the highlight groups were setup using hi def but that was missing for those groups under DEFAULT_DEFS.

I use catppuccin's custom_highlights to override NvimTreeFolderIcon and NvimTreeWindowPicker, which did not work in overriding the default highlights after the recently pushed commits.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the fast find and fix!

Tested before and after nvim-tree setup:

require("catppuccin").setup({
  flavour = "macchiato",
  background = {
    light = "latte",
    dark = "mocha",
  },
  highlight_overrides = {
    all = function(colors)
      return {
        NvimTreeNormal = { fg = colors.red, bg = colors.flamingo },
        NvimTreeFolderIcon = { fg = colors.green, bg = colors.yellow },
        NvimTreeWindowPicker = { fg = colors.blue, bg = colors.pink },
      }
    end,
  },
  integrations = {
    -- nvimtree = true,
    nvimtree = false,
  },
})
vim.cmd.colorscheme("catppuccin")

@alex-courtis alex-courtis merged commit 74525ac into nvim-tree:master Jan 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants