Fix run list for non-cmake targets #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced in #639 was only looking for cmake targets, did not account for pure python targets Signed-off-by: Alexis Girault <[email protected]>
Ignore {{cookiecutter.project_slug}}
Signed-off-by: Alexis Girault <[email protected]>
agirault
force-pushed
the
ag/fix-run-list
branch
from
6855079 to
54fba4f
Compare
campnarvis
pushed a commit
to TUM-CAMP-NARVIS/holohub-narvis
that referenced
this pull request
Dec 26, 2024
* Fix run list for non-cmake targets Regression introduced in nvidia-holoscan#639 was only looking for cmake targets, did not account for pure python targets Signed-off-by: Alexis Girault <[email protected]> * Ignore templated pathname in run list Ignore {{cookiecutter.project_slug}} Signed-off-by: Alexis Girault <[email protected]> --------- Signed-off-by: Alexis Girault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #639
was only looking for cmake targets, did not account for pure python targets
Before: 53 apps.
After:
9796 apps.