revert: remove unnecessary hmr regex

nuxt-community · May 7, 2019 · 1ac5f5c · 1ac5f5c
1 parent 913897a
commit 1ac5f5c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 81 deletions.
diff --git a/docs/modules/workbox.md b/docs/modules/workbox.md
@@ -145,15 +145,15 @@ Workbox takes a lot of the heavy lifting out of precaching by simplifying the AP
 
 Default is auto generated based on `publicPath`. Supports CDN too.
 
-Default: `/_nuxt/(?!.*(__webpack_hmr|hot-update))`
+Default: `/_nuxt/`
 
 ### `pagesURLPattern`
 
 (String/Regex) Pattern to match pages to be offlined.
 
 Default is auto generated based on `router.base`.
 
-Default: `/(?!.*(__webpack_hmr|hot-update))`
+Default: `/`
 
 <!-- SW -->
 

diff --git a/packages/workbox/lib/options.js b/packages/workbox/lib/options.js
@@ -3,8 +3,6 @@ const path = require('path')
 const defaults = require('./defaults')
 const { joinUrl, getRouteParams, startCase } = require('@nuxtjs/pwa-utils')
 
-const HMRRegex = '(?!.*(__webpack_hmr|hot-update))'
-
 function getOptions (moduleOptions) {
   const options = Object.assign({}, defaults, moduleOptions, this.options.workbox)
 
@@ -40,7 +38,7 @@ function getOptions (moduleOptions) {
 
   // Cache all _nuxt resources at runtime
   if (!options.assetsURLPattern) {
-    options.assetsURLPattern = joinUrl(options.publicPath, HMRRegex)
+    options.assetsURLPattern = options.publicPath
   }
   if (options.cacheAssets) {
     options.runtimeCaching.push({
@@ -51,7 +49,7 @@ function getOptions (moduleOptions) {
 
   // Optionally cache other routes for offline
   if (!options.pagesURLPattern) {
-    options.pagesURLPattern = joinUrl(options.routerBase, HMRRegex)
+    options.pagesURLPattern = options.routerBase
   }
   if (options.offline && !options.offlinePage) {
     options.runtimeCaching.push({

diff --git a/test/__snapshots__/pwa.test.js.snap b/test/__snapshots__/pwa.test.js.snap
@@ -106,10 +106,10 @@ workbox.precaching.precacheAndRoute([
 
 // Register route handlers for runtimeCaching
 workbox.routing.registerRoute(new RegExp('https://google.com/.*'), new workbox.strategies.CacheFirst ({}), 'GET')
-workbox.routing.registerRoute(new RegExp('/_nuxt/(?!.*(__webpack_hmr|hot-update))'), new workbox.strategies.CacheFirst ({}), 'GET')
+workbox.routing.registerRoute(new RegExp('/_nuxt/'), new workbox.strategies.CacheFirst ({}), 'GET')
 
 // Register router handler for offlinePage
-workbox.routing.registerRoute(new RegExp('/(?!.*(__webpack_hmr|hot-update))'), ({event}) => {
+workbox.routing.registerRoute(new RegExp('/'), ({event}) => {
   return new workbox.strategies.NetworkFirst().handle({event})
     .catch(() => caches.match('/offline.html'))
 })

diff --git a/test/hmr.js b/test/hmr.js