Feature lts2021 csp changes part2 #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alokhyland
requested review from
MohinishSah and
aradhanas9
and removed request for
a team
alokhyland
force-pushed
the
feature-lts2021-csp-changes-part2
branch
from
a0a5503 to
9e00c20
Compare
madhurkulshrestha-hyland
requested changes
Dec 16, 2024
| String cspHeader = resp.getHeader("Content-Security-Policy"); | ||
| String newCspHeader = ""; | ||
| boolean isnewCspHeaderEmpty = false; | ||
| if(cspHeader != null && cspHeader.trim().isEmpty()) { |
There was a problem hiding this comment.
cspHeader == null || cspHeader.trim().isEmpty()
| String newCspHeader = ""; | ||
| boolean isnewCspHeaderEmpty = false; | ||
| if(cspHeader != null && cspHeader.trim().isEmpty()) { | ||
| isnewCspHeaderEmpty = true; |
There was a problem hiding this comment.
isExistingCspHeaderEmpty
| boolean foundScriptSrcMatch = false; | ||
| boolean foundObjectSrcMatch = false; | ||
| for (int i = 0; i < directives.length; i++) { | ||
| String directive = directives[i].trim(); |
There was a problem hiding this comment.
declare directive as String outside the for loop
alokhyland
force-pushed
the
feature-lts2021-csp-changes-part2
branch
from
9e00c20 to
aec4105
Compare
madhurkulshrestha-hyland
approved these changes
Dec 16, 2024
alokhyland
requested review from
rakeshkumar1019,
swarnadipa-dev and
rahuljain-dev
and removed request for
MohinishSah and
aradhanas9
rahuljain-dev
approved these changes
Dec 17, 2024
rakeshkumar1019
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.