Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEBUI-1511-BACKPORT:REVERT-Own Code Static Scan Open Redirect #2252

Merged
merged 1 commit into from
Jun 5, 2024
Merged

WEBUI-1511-BACKPORT:REVERT-Own Code Static Scan Open Redirect #2252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions elements/routing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,36 +27,6 @@ function scrollToTop(ctx, next) {
next();
}

function createUrlFromString(str) {
const httpRegex = /^https?:\/\//;
const wwwRegex = /www\./;
str = httpRegex.test(str) ? str : `http://${str}`;
str = wwwRegex.test(str) ? str : str.replace(/^(https?:\/\/)?/, '$1www.');
return str;
}

function isTrustedDomain(path) {
const trustedDomains = Nuxeo && Nuxeo.UI && Nuxeo.UI.config && Nuxeo.UI.config.trustedDomains;
if (!trustedDomains) return true;
const modifiedPathUrl = createUrlFromString(path);
const pathUrl = new URL(modifiedPathUrl);
const { hostname: userHostName } = pathUrl;
const trustedDomainList = trustedDomains.split(',');
const isValidUrl = trustedDomainList.some((url) => {
const updatedUrl = createUrlFromString(url);
const { hostname: currentUrlHostName } = new URL(updatedUrl);
return currentUrlHostName?.toLowerCase() === userHostName?.toLowerCase();
});
return isValidUrl;
}

function encodeQueryParams(path) {
const pathUrl = new URL(path);
const queryParams = pathUrl.search.split('?')[1];
const encodepath = queryParams ? `${pathUrl.origin}?${encodeURIComponent(queryParams)}` : path;
return encodepath;
}

function _routeAdmin(selectedAdminTab, errorPath, routeData) {
const hasPermission =
app.currentUser.isAdministrator || app.currentUser.extendedGroups.find((grp) => grp.name === 'powerusers');
Expand Down Expand Up @@ -226,13 +196,7 @@ app.router = {
}
const isFullpath = /^http(s)?:\/\//.test(path);
if (isFullpath) {
const isValidUrl = isTrustedDomain(path);
if (isValidUrl) {
const encodepath = encodeQueryParams(path);
const link = document.createElement('a');
link.setAttribute('href', encodepath);
link.click();
}
window.location = path;
} else {
page(path);
}
Expand Down
3 changes: 0 additions & 3 deletions plugin/web-ui/addon/src/main/resources/OSGI-INF/web-ui-properties.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,5 @@
<!-- Properties to be fetched when loading the user object in user management, default is empty -->
<property name="org.nuxeo.web.ui.user.management.fetch.document" list="true"></property>

<!-- allowed url to redirect -->
<property name="org.nuxeo.web.ui.trustedDomains">${org.nuxeo.web.ui.trustedDomains:=''}</property>

</extension>
</component>
Loading