WEBUI-1385: Fix update of Template properties #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alokhyland
requested review from
rakeshkumar1019 and
abhishekkumar31
and removed request for
abhishekkumar31
alokhyland
force-pushed
the
fix-WEBUI-1385-fix-update-of-template-properties
branch
from
eb82888
to
4bb9716
Compare
swarnadipa-dev
previously approved these changes
Feb 12, 2024
alokhyland
force-pushed
the
fix-WEBUI-1385-fix-update-of-template-properties
branch
from
4bb9716
to
bd40e0e
Compare
madhurkulshrestha-hyland
requested changes
Feb 22, 2024
addons/nuxeo-template-rendering/elements/nuxeo-template-rendering-page.js
Outdated
Show resolved
Hide resolved
addons/nuxeo-template-rendering/elements/nuxeo-template-rendering-page.js
Outdated
Show resolved
Hide resolved
addons/nuxeo-template-rendering/elements/nuxeo-template-rendering-page.js
Outdated
Show resolved
Hide resolved
alokhyland
force-pushed
the
fix-WEBUI-1385-fix-update-of-template-properties
branch
from
bd40e0e
to
34767a6
Compare
alokhyland
force-pushed
the
fix-WEBUI-1385-fix-update-of-template-properties
branch
from
34767a6
to
f043798
Compare
madhurkulshrestha-hyland
previously approved these changes
Feb 23, 2024
rahuljain-dev
force-pushed
the
fix-WEBUI-1385-fix-update-of-template-properties
branch
from
f043798
to
66957bb
Compare
Nishant0928
previously approved these changes
Feb 27, 2024
| this.set('editedDocument', this._parseJSON(this.document)); | ||
| }, | ||
|
|
||
| _findChangedValues(object1, object2) { |
There was a problem hiding this comment.
please change object1, object2 parameter names to something that is understandable in context of the code.
alokhyland
dismissed stale reviews from Nishant0928 and madhurkulshrestha-hyland
via
02655f5
alokhyland
force-pushed
the
fix-WEBUI-1385-fix-update-of-template-properties
branch
from
66957bb
to
02655f5
Compare
swarnadipa-dev
approved these changes
Feb 27, 2024
madhurkulshrestha-hyland
approved these changes
Feb 27, 2024
Nishant0928
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.