Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBUI-992-BACKPORT: prevent replacing and removing an attachment under retention on when using nuxeo-dropzone #1920

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions elements/nuxeo-dropzone/nuxeo-dropzone.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ Polymer({
</template>
</div>

<div id="dropzone" hidden$="[[!_isDropzoneVisible(hasFiles, multiple, updateDocument, blobList)]]">
<div id="dropzone" hidden$="[[!_isDropzoneVisible(document, hasFiles, multiple, updateDocument, blobList)]]">
<div id="container">
<button class="link" on-click="open">
[[_computeMessage(draggingFiles, message, dragContentMessage, i18n)]]
Expand Down Expand Up @@ -585,7 +585,18 @@ Polymer({
return this.i18n && this.draggingFiles ? this.i18n(this.dragContentMessage) : this.i18n(this.message);
},

_isDropzoneVisible() {
_isDropzoneVisible(document) {
if (
document &&
document.isUnderRetentionOrLegalHold &&
document.retainedProperties &&
document.retainedProperties.length > 0
) {
if (document.retainedProperties.indexOf(this.xpath) !== -1) {
return false;
}
}

// Area to drop files should stay visible when the element is attached to a blob list property
// and, e.g, when using the element on a form: creation or edition of documents.
// This will allow the user to manage the list of files.
Expand Down
49 changes: 49 additions & 0 deletions test/nuxeo-dropzone.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/**
@license
©2023 Hyland Software, Inc. and its affiliates. All rights reserved.
All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import { fixture, html } from '@nuxeo/testing-helpers';
import '../elements/nuxeo-dropzone/nuxeo-dropzone';

suite('nuxeo-dropzone', () => {
let element;
setup(async () => {
element = await fixture(
html`
<nuxeo-dropzone></nuxeo-dropzone>
`,
);
});

suite('should return whether property is under retention', () => {
const document = {
isUnderRetentionOrLegalHold: true,
retainedProperties: ['checkext:single', 'file:content'],
};
test('when xpath = checkext:single', () => {
element.xpath = 'checkext:single';
expect(element._isDropzoneVisible(document)).to.eql(false);
});
test('when xpath = checkext:multiple', () => {
element.xpath = 'checkext:multiple';
expect(element._isDropzoneVisible(document)).to.eql(true);
});
test('when xpath = file:content, for document viewer', () => {
element.xpath = 'file:content';
expect(element._isDropzoneVisible(document)).to.eql(false);
});
});
});
Loading