WEBUI-1224: (Backport) expose value-key on nuxeo-document-attachments. #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poonamyadav252
force-pushed
the
fix-WEBUI-1224-expose-value-key-on-nuxeo-document-attachments-backport
branch
from
23ebaf8
to
ebca672
Compare
poonamyadav252
requested review from
rakeshkumar1019,
rajatgoel-gl and
Nishant0928
and removed request for
swarnadipa-dev and
Nisha-QA
There was a problem hiding this comment.
Here, creating a new variablefileName can be omitted.
return this.document.type === 'File' && this.xpath === 'files:files' ? 'file' : '';
@rakeshkumar1019 yes, it can be, but we already merge the code in maintenance-3.1.x so we can't change it because we need to make a sync between both repo.
Nishant0928
approved these changes
Jul 31, 2023
rakeshkumar1019
approved these changes
Jul 31, 2023
rajatgoel-gl
approved these changes
Aug 1, 2023
poonamyadav252
deleted the
fix-WEBUI-1224-expose-value-key-on-nuxeo-document-attachments-backport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.