Skip to content

Commit

Permalink
WEBUI-992: prevent replacing and removing an attachment under retenti…
Browse files Browse the repository at this point in the history
…on when using nuxeo-dropzone
  • Loading branch information
poonamyadav252 authored and Nishant0928 committed Aug 7, 2023
1 parent 3354ca1 commit ed43cff
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ Polymer({
},

_getFileValue() {
const fileName = this.document.type === 'File' && this.xpath === 'files:files' ? 'file' : '';
return fileName;
return this.xpath === 'files:files' ? 'file' : '';
},
});
15 changes: 13 additions & 2 deletions elements/nuxeo-dropzone/nuxeo-dropzone.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ Polymer({
</template>
</div>
<div id="dropzone" hidden$="[[!_isDropzoneVisible(hasFiles, multiple, updateDocument, blobList)]]">
<div id="dropzone" hidden$="[[!_isDropzoneVisible(document, hasFiles, multiple, updateDocument, blobList)]]">
<div id="container">
<button class="link" on-click="open">
[[_computeMessage(draggingFiles, message, dragContentMessage, i18n)]]
Expand Down Expand Up @@ -581,7 +581,18 @@ Polymer({
return this.i18n && this.draggingFiles ? this.i18n(this.dragContentMessage) : this.i18n(this.message);
},

_isDropzoneVisible() {
_isDropzoneVisible(document) {
if (
document &&
document.isUnderRetentionOrLegalHold &&
document.retainedProperties &&
document.retainedProperties.length > 0
) {
if (document.retainedProperties.indexOf(this.xpath) !== -1) {
return false;
}
}

// Area to drop files should stay visible when the element is attached to a blob list property
// and, e.g, when using the element on a form: creation or edition of documents.
// This will allow the user to manage the list of files.
Expand Down
49 changes: 49 additions & 0 deletions test/nuxeo-dropzone.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/**
@license
©2023 Hyland Software, Inc. and its affiliates. All rights reserved.
All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import { fixture, html } from '@nuxeo/testing-helpers';
import '../elements/nuxeo-dropzone/nuxeo-dropzone';

suite('nuxeo-dropzone', () => {
let element;
setup(async () => {
element = await fixture(
html`
<nuxeo-dropzone></nuxeo-dropzone>
`,
);
});

suite('should return whether property is under retention', () => {
const document = {
isUnderRetentionOrLegalHold: true,
retainedProperties: ['checkext:single', 'file:content'],
};
test('when xpath = checkext:single', () => {
element.xpath = 'checkext:single';
expect(element._isDropzoneVisible(document)).to.eql(false);
});
test('when xpath = checkext:multiple', () => {
element.xpath = 'checkext:multiple';
expect(element._isDropzoneVisible(document)).to.eql(true);
});
test('when xpath = file:content, for document viewer', () => {
element.xpath = 'file:content';
expect(element._isDropzoneVisible(document)).to.eql(false);
});
});
});

0 comments on commit ed43cff

Please sign in to comment.