Test dt adapter

[gitofanindya]

Summary by Sourcery

Upgrade the Python version to 3.12 across various CI workflows and update the pywin32 dependency to version 306. Modify datetime handling to use timezone-aware datetime objects. Update documentation to reflect the new Python version support.

Enhancements:

• Update the pywin32 dependency to version 306 in the requirements file.

CI:

• Upgrade the Python version to 3.12 in multiple GitHub Actions workflows, including functional, unit, integration, lint, spell, style, translations, and types tests.

Documentation:

• Update documentation to reflect support for Python 3.12.3 instead of 3.9.5.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements datetime handling improvements and upgrades Python version from 3.9 to 3.12. The main changes focus on proper timezone handling in datetime operations and adapting datetime objects for SQLite storage. The PR also includes dependency updates and removal of unused code.

Class diagram for AutoRetryCursor modifications

classDiagram
    class AutoRetryCursor {
        +adapt_datetime_iso(val)
        +execute(sql: str, parameters: Iterable[Any])
    }
    note for AutoRetryCursor "Added adapt_datetime_iso method and modified execute method to handle datetime objects with timezone."

Loading

Class diagram for datetime handling changes

classDiagram
    class datetime {
        +fromtimestamp(timestamp, tz)
        +now(tz)
    }
    note for datetime "Updated usage to include timezone-aware datetime operations."

Loading

File-Level Changes

Change	Details	Files
Improved datetime handling with explicit timezone information	Replaced datetime.utcnow() with datetime.now(tz=timezone.utc) Added timezone handling in SQLite adapter Updated datetime conversion for file modification times	nxdrive/dao/base.py nxdrive/dao/engine.py nxdrive/client/local/base.py nxdrive/engine/engine.py nxdrive/engine/watcher/remote_watcher.py
Upgraded Python version from 3.9 to 3.12	Updated Python version in all CI workflow files Updated documentation to reflect new Python version Updated deployment scripts with new Python version	.github/workflows/functional_tests.yml .github/workflows/unit_tests.yml .github/workflows/dead_code.yml .github/workflows/integration_tests.yml docs/deployment.md docs/gnu_linux.md docs/support.md tools/posix/deploy_ci_agent.sh tools/windows/deploy_ci_agent.ps1
Updated dependencies and removed unused code	Updated pywin32 from version 301 to 306 Removed unused MockedPath class Modified database cleanup approach in tests	tools/deps/requirements.txt tests/unit/test_utils.py tests/unit/conftest.py tests/unit/test_proxy.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @gitofanindya - I've reviewed your changes - here's some feedback:

Overall Comments:

• The sqlite datetime adapter implementation in AutoRetryCursor needs cleanup - remove commented code and avoid direct sqlite3 imports. Consider using the standard sqlite3 date adapters.
• The removal of MockedPath test class reduces test coverage. Please either restore the test coverage or document why these tests are no longer needed.
• Using os.system() for directory removal is unsafe and platform-dependent. Please use pathlib or shutil functions instead.

Here's what I looked at during the review

• 🟡 General issues: 3 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 2 issues found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue: The strftime('%s') format specifier is not guaranteed to work on all platforms, particularly Windows

[sourcery-ai]

suggestion: Use context manager pattern for database connection to ensure proper cleanup

This ensures the connection is closed even if an exception occurs during the dump process.

Suggested change

	con = sqlite3.connect(str(database))
	with dump_file.open(mode="w", encoding="utf-8") as f:
	for line in con.iterdump():
	f.write(f"{line}\n")
	# Force write of file to disk
	f.flush()
	fsync(f.fileno())
	con.close()
	with sqlite3.connect(str(database)) as con, dump_file.open(mode="w", encoding="utf-8") as f:
	for line in con.iterdump():
	f.write(f"{line}\n")
	# Force write of file to disk
	f.flush()
	fsync(f.fileno())

[sourcery-ai]

issue (bug_risk): Incorrect index used for locale code - should be [0] instead of [1]

Index [1] returns the encoding instead of the locale code. This will cause incorrect locale detection.

[sourcery-ai]

issue (testing): Using os.system() for test cleanup is unsafe

Using os.system() for file operations in tests is not recommended as it's platform-dependent and can be unsafe. Consider using pathlib.Path.unlink() or shutil.rmtree() for more reliable cleanup.

[sourcery-ai]

issue (testing): Same unsafe cleanup pattern in test_proxy.py

Similar to the issue in conftest.py, using os.system() for cleanup is not recommended. Use standard Python file operations instead.