Issue#304: Detect all theme patterns. #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on this! |
|
This just solved our problem with patterns not showing up in a multi-domain setup, where we use a different theme for each domain: Our steps to reproduce (We only use patterns on domain 2)
Oddly, once we deinstall ui_patterns_library, the patterns will never show up. |
|
Moved to Drupal.org https://www.drupal.org/project/ui_patterns/issues/3311471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve multiple issues originating from the
\Drupal\ui_patterns_library\Plugin\Deriver\LibraryDeriver::getDirectoriesmethod collecting only the default theme and the base theme directories.Besides the issues described in #304 and #308, I also had errors during site install with existing config, when using patterns in layout builder, because during install the default theme is stark.
This PR is a follow up to PRs #305 and #310 and uses the method suggested here: #304 (comment)