Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PHP TypeError when asserting for a non-visible field #67

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

mediabounds
Copy link

When asserting for a non-visible field, there is a type error:

Type error: NuvoleWeb\Drupal\DrupalExtension\Context\VisibilityContext::assertElementNotVisible(): Argument #2 ($node) must be of type Behat\Mink\Element\NodeElement, null given, called in vendor/nuvoleweb/drupal-behat/src/DrupalExtension/Context/VisibilityContext.php on line 64

Ironically, this TypeError indicates success—the element could not be found so the argument is null. But the TypeError causes the tests to fail. This PR adjusts the type arguments to allow NULL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant