Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate service IDs are unique #91

Closed
wants to merge 2 commits into from
Closed

Validate service IDs are unique #91

wants to merge 2 commits into from

Conversation

reinkrul
Copy link
Member

Required check for consumers according to https://www.w3.org/TR/did-core/#services

gerardsn
gerardsn approved these changes Oct 27, 2023
View reviewed changes
did/validator.go Outdated Show resolved Hide resolved
@reinkrul
Copy link
Member Author

Before merging, we need to check on Nuts dev, stable, test and prd networks whether there are DID documents with duplicate service IDs. Shouldn't be possible (since the ID is a hash of the endpoint) but it could be.

@woutslakhorst
Copy link
Member

Before merging, we need to check on Nuts dev, stable, test and prd networks whether there are DID documents with duplicate service IDs. Shouldn't be possible (since the ID is a hash of the endpoint) but it could be.

Possible disastrous consequences, any benefits apart from following the specs?

@reinkrul
Copy link
Member Author

reinkrul commented Dec 1, 2023

Probably no added benefits for now.

@reinkrul reinkrul closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardsn gerardsn gerardsn approved these changes

@woutslakhorst woutslakhorst Awaiting requested review from woutslakhorst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reinkrul @woutslakhorst @gerardsn