[W13-3] Task Book #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the code in our the code base only puts a single space between
non-whitespace characters,
"Like " + "this."
It is highly likely that there will not be a case where we will need to
put more than a single space between non-whitespace characters,
"Like " + "this."
To enforce consistency throughout the code base, let's add the
SingleSpaceSeparator module to our checkstyle configuration, and fix all
of the existing violations in our code base.
When run in head-full mode, HelpWindowTest fails with the following
exception:
seedu.address.ui.HelpWindowTest > focus_helpWindowNotFocused_focused FAILED
java.lang.AssertionError at HelpWindowTest.java:64
The line in question is from the following:
assertFalse(helpWindow.getRoot().isFocused());
which comes right after:
// Focus on another stage to remove focus from the helpWindow
FxToolkit.setupStage(Stage::requestFocus);
However, despite what the comment claims, the call to
FxToolkit.setupStage(...) does not "focus on another stage". This is
because the Stage registered with TestFX is the HelpWindow stage itself.
In other words, we are just requesting the HelpWindow to focus itself,
which is the complete opposite of "removing focus from the helpWindow".
This "focus on another stage" code was written in 1c6071f
(HelpWindowTest: fix failing test in non-headless mode, 2018-04-16). At
that point in time, the stage registered with TestFX _was_ "another
stage"[1] and so the code was correct. However, in a42eded (Fix
stalling HelpWindowTest, 2018-06-26) this was changed such that the
stage registered with TestFX is the HelpWindow stage itself. Yet, the
code was not modified to properly operate in the new world order[2].
Fix this piece of code by creating a temporary stage to focus on, so
that the goal of "removing focus from the helpWindow" is properly
achieved.
[1]: Somewhat-ish. The full story can be found in a42eded (Fix stalling
HelpWindowTest, 2018-06-26).
[2]: And obviously, the author did not run tests in head-full mode :-S
Modified comments to avoid checkstyle errors
* Modified aboutUs page: Ks * Updated UG and DG for viewDate + selectDate
Edited the developer guide corrected developer guide Added user stories Minor changes to docs
* Updated UG and DG for addTask + addDeadline * Added new feature: defer deadline
# Conflicts: # docs/DeveloperGuide.adoc # docs/UserGuide.adoc
Added mockup UI + a formatting mistake in DG (#6) * Minor adjustments to DG * Replaced AB Ui with TB mockup Ui edit pics
# Conflicts: # docs/DeveloperGuide.adoc
… include them as well
Updated UG & Jeremy's PPP
* Updated UG and DG for viewDate + selectDate (#2) * Modified aboutUs page: Ks * Updated UG and DG for viewDate + selectDate * Commands to understand things better (CC) * changed github account link * About us - Chan Chun Cheong * Profile Picture * Delete profile picture.jpeg * ChanChunCheong * Edited About Us to enable the picture * Edited the User Guide * Edited the developer guide * corrected developer guide * Added user stories * Added new feature: defer deadline * Solved Merged conflict * edited the developer guide * edited developers guide again to solve merge conflict * Renamed AddressBook to TaskBook * Added Tasks + AddTask with some refactoring, still have errors in building * Added PriorityLevel into Task * Copied Khasim's Deadline class and teach the app to accept 'remark' but do nothing * Teach the app to accept 'defer deadline' but do nothing (include testing) * Added comments for better understanding. * made some changes * edited DG to get similar files to Org Repo master * added back the photo * removed test file * added photo * Added Tag Class * Teach the app to accept 'SortTask' but do nothing * Teach the app to accept 'sort' arguments but still do nothing * reject invalid sort methods * Module Code reflected on UI and SortTask has been implemented to UniqueTaskList * Able to sort the task list with SortTask command. Changes reflected on UI * Added SortTaskList to sort the task and return it back to UniqueTaskList * Added sorting methods of priority and title * Solved SortTask. * Solved SortTask by priority * Annnotated code * Case Insensitive Command * Test and CheckStyle are resolved. * corrected to be the same as org_repo master * edited the defer deadline to enable i/ dd/ mm/ yyyy/ * updated UG * Corrected checkstyle error and edited user guide * edited UG for Kha Sim and CC * Final edits to deferDeadline and selectDate's UG * addtag * Add_tag command * Changed TreeSet to HashSet. AddTag Command works perfectly. * Added RemoveTag function * Select Tag Command working. Checkstyle passed * DeferDeadine Command changed. * Test and CheckStyle passed * Solved DeferDeadline bug and Added DeferDeadline Command test * Solved removing non-existent tag bug and tag must be alphanumeric bug. * Solved the deferdeadline which resulted in the sametask bug. Changed the way deferdeadline is implemented * DeferDeadline, RemoveTag, SelectTag, AddTag Command Parsers Tests. DeferDeadline, RemoveTag, SelectTag, AddTag Command Tests. * Added tests for AddTag, DeferDeadline, RemoveTag. * annotated authorship * SortTaskCommandParser implemented * All test cases passed * All tests passed and checkstyle passed
* Updated UG and DG for viewDate + selectDate (#2) * Modified aboutUs page: Ks * Updated UG and DG for viewDate + selectDate * Commands to understand things better (CC) * changed github account link * About us - Chan Chun Cheong * Profile Picture * Delete profile picture.jpeg * ChanChunCheong * Edited About Us to enable the picture * Edited the User Guide * Edited the developer guide * corrected developer guide * Added user stories * Added new feature: defer deadline * Solved Merged conflict * edited the developer guide * edited developers guide again to solve merge conflict * Renamed AddressBook to TaskBook * Added Tasks + AddTask with some refactoring, still have errors in building * Added PriorityLevel into Task * Copied Khasim's Deadline class and teach the app to accept 'remark' but do nothing * Teach the app to accept 'defer deadline' but do nothing (include testing) * Added comments for better understanding. * made some changes * edited DG to get similar files to Org Repo master * added back the photo * removed test file * added photo * Added Tag Class * Teach the app to accept 'SortTask' but do nothing * Teach the app to accept 'sort' arguments but still do nothing * reject invalid sort methods * Module Code reflected on UI and SortTask has been implemented to UniqueTaskList * Able to sort the task list with SortTask command. Changes reflected on UI * Added SortTaskList to sort the task and return it back to UniqueTaskList * Added sorting methods of priority and title * Solved SortTask. * Solved SortTask by priority * Annnotated code * Case Insensitive Command * Test and CheckStyle are resolved. * corrected to be the same as org_repo master * edited the defer deadline to enable i/ dd/ mm/ yyyy/ * updated UG * Corrected checkstyle error and edited user guide * edited UG for Kha Sim and CC * Final edits to deferDeadline and selectDate's UG * addtag * Add_tag command * Changed TreeSet to HashSet. AddTag Command works perfectly. * Added RemoveTag function * Select Tag Command working. Checkstyle passed * DeferDeadine Command changed. * Test and CheckStyle passed * Solved DeferDeadline bug and Added DeferDeadline Command test * Solved removing non-existent tag bug and tag must be alphanumeric bug. * Solved the deferdeadline which resulted in the sametask bug. Changed the way deferdeadline is implemented * DeferDeadline, RemoveTag, SelectTag, AddTag Command Parsers Tests. DeferDeadline, RemoveTag, SelectTag, AddTag Command Tests. * Added tests for AddTag, DeferDeadline, RemoveTag. * annotated authorship * SortTaskCommandParser implemented * All test cases passed * All tests passed and checkstyle passed * Inserted tag test and updated userguide * removed unnecessary comments * clean up code. Added Command Exception to deferdeadline to prevent deadline from exceeding 31/12/9999 * Edited SortTaskCommand, test and its UG * User Guide done. Added personal project portfolio
* Updated UG and DG for selectDeadline and editTask * Updated Ks PPP
* Minor formatting issue for FAQ in UG * Minor formatting issues for UG and Jeremy's PPP * Updated UG, DG for milestone related features and Jeremy's PPP * Minor formatting issue for add_milestone feature in UG * Minor addition to DG
Documentation modifications
* Minor formatting issue for FAQ in UG * Minor formatting issues for UG and Jeremy's PPP * Updated UG, DG for milestone related features and Jeremy's PPP * Minor formatting issue for add_milestone feature in UG * Minor addition to DG * Minor changes to UG * Edited use case for add milestone in DG * Minor changes to ensure WARNING works for UG
* Updated UG and DG for viewDate + selectDate (#2) * Modified aboutUs page: Ks * Updated UG and DG for viewDate + selectDate * Commands to understand things better (CC) * changed github account link * About us - Chan Chun Cheong * Profile Picture * Delete profile picture.jpeg * ChanChunCheong * Edited About Us to enable the picture * Edited the User Guide * Edited the developer guide * corrected developer guide * Added user stories * Added new feature: defer deadline * Solved Merged conflict * edited the developer guide * edited developers guide again to solve merge conflict * Renamed AddressBook to TaskBook * Added Tasks + AddTask with some refactoring, still have errors in building * Added PriorityLevel into Task * Copied Khasim's Deadline class and teach the app to accept 'remark' but do nothing * Teach the app to accept 'defer deadline' but do nothing (include testing) * Added comments for better understanding. * made some changes * edited DG to get similar files to Org Repo master * added back the photo * removed test file * added photo * Added Tag Class * Teach the app to accept 'SortTask' but do nothing * Teach the app to accept 'sort' arguments but still do nothing * reject invalid sort methods * Module Code reflected on UI and SortTask has been implemented to UniqueTaskList * Able to sort the task list with SortTask command. Changes reflected on UI * Added SortTaskList to sort the task and return it back to UniqueTaskList * Added sorting methods of priority and title * Solved SortTask. * Solved SortTask by priority * Annnotated code * Case Insensitive Command * Test and CheckStyle are resolved. * corrected to be the same as org_repo master * edited the defer deadline to enable i/ dd/ mm/ yyyy/ * updated UG * Corrected checkstyle error and edited user guide * edited UG for Kha Sim and CC * Final edits to deferDeadline and selectDate's UG * addtag * Add_tag command * Changed TreeSet to HashSet. AddTag Command works perfectly. * Added RemoveTag function * Select Tag Command working. Checkstyle passed * DeferDeadine Command changed. * Test and CheckStyle passed * Solved DeferDeadline bug and Added DeferDeadline Command test * Solved removing non-existent tag bug and tag must be alphanumeric bug. * Solved the deferdeadline which resulted in the sametask bug. Changed the way deferdeadline is implemented * DeferDeadline, RemoveTag, SelectTag, AddTag Command Parsers Tests. DeferDeadline, RemoveTag, SelectTag, AddTag Command Tests. * Added tests for AddTag, DeferDeadline, RemoveTag. * annotated authorship * SortTaskCommandParser implemented * All test cases passed * All tests passed and checkstyle passed * Inserted tag test and updated userguide * removed unnecessary comments * clean up code. Added Command Exception to deferdeadline to prevent deadline from exceeding 31/12/9999 * Edited SortTaskCommand, test and its UG * User Guide done. Added personal project portfolio * updated the user guide guide, about us and personal portfolio page * update UG and PPP * edit to DG * added user case * last update
Reposense edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChanChunCheong @JeremyInElysium @emobeany