Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W5.6a][T16-1]Gian Zhi Cai #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[W5.6a][T16-1]Gian Zhi Cai #187

wants to merge 1 commit into from

Conversation

zhicaizack
Copy link

Extracted commonalities from Phone, Email and Address classes into a parent class called Contact.

@zhicaizack
Exercise: Extract a Contact class
d226ef0 
Extract commonalities from Phone, Email and Address classes into a parent class called Contact.
stephlewyh
stephlewyh reviewed Sep 20, 2018
View reviewed changes
Copy link

@stephlewyh stephlewyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good try!

Note that if your equals() is overridden then hashCode() also needs to be overridden.

You may also explore:
(1) declaring Contact class as an abstract class
(2) pushing subclass constructor code to superclass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephlewyh stephlewyh stephlewyh left review comments

@okkhoy okkhoy Awaiting requested review from okkhoy

Assignees

@stephlewyh stephlewyh

Labels
Accepted W/ Minimal Review team.1 tutorial.T16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhicaizack @stephlewyh @nus-se-pr-bot