[W5.11][F10-2] Ong Jia Jian #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simple but very practical enhancement. Great job |
|
A necessary improvement as users might not remember how the contact was saved in terms of case sensitivity |
|
An improvement that is very considerate of users. Nice! |
fanyiii
reviewed
Sep 15, 2018
| @@ -40,7 +40,7 @@ public static boolean isValidName(String test) { | |||
| * Retrieves a listing of every word in the name, in order. | |||
| */ | |||
| public List<String> getWordsInName() { | |||
| return Arrays.asList(fullName.split("\\s+")); | |||
| return Arrays.asList(fullName.toLowerCase().split("\\s+")); | |||
There was a problem hiding this comment.
what's the implication of converting all words to lower case here? (what if later on you need to retrieve the words in their original forms). Think of a better place to do the conversion, or perhaps add a new method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made 'find' case insensitive and updated expected output and user guide
Ready for Review!