Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5.11][F09-2]Lim Kian Hong #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kianhong95
Copy link

Added case-sensitive feature (Able to enter commands no matter if it is upper or lower case)

@AngWM
Copy link

AngWM commented Sep 13, 2018

Best feature added. Who wants case sensitive input anyway

@px1099
Copy link

px1099 commented Sep 13, 2018

Added case-sensitive feature (Able to enter commands no matter if it is upper or lower case)

Did you mean "Add case-insensitive feature"?

@px1099
Copy link

px1099 commented Sep 13, 2018

  • Great feature for people who broke their CapsLock key
  • Made with minimal changes of the program
  • User guide was updated
  • Test cases for Windows & Mac were added

Copy link

@stephlewyh stephlewyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kian Hong, great job in providing a comprehensive test case for your simple enhancement! You may wish to use a description like "Commands provided by user can be case-insensitive."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants