[W5.11][T12-3] Davindran #165
Conversation
|
Hi @Davindran, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
Davindran
changed the title
There was a problem hiding this comment.
@Davindran Good job at using branching and updating comments and documentation! Also nice that you gave your commit a meaningful name.
Please close this PR after reading review comments
| @@ -79,17 +79,17 @@ Format: `find KEYWORD [MORE_KEYWORDS]` | |||
|
|
|||
| [NOTE] | |||
| ==== | |||
| The search is case sensitive, the order of the keywords does not matter, only the name is searched, | |||
| The search is NOT case sensitive, the order of the keywords does not matter, only the name is searched, | |||
| @@ -176,10 +176,20 @@ Example: | |||
|
|
|||
| * `java seedu.addressbook.Main mydata.txt` | |||
|
|
|||
| == ENHANCEMENT | |||
There was a problem hiding this comment.
Don't have to add this if you've mentioned it above in the find command description (:
| @@ -11,13 +11,14 @@ | |||
| /** | |||
| * Finds and lists all persons in address book whose name contains any of the argument keywords. | |||
| * Keyword matching is case sensitive. | |||
| * ENHANCEMENT: keyword matching is NOT case sensitive. | |||
| @@ -14,7 +14,7 @@ | |||
| || Example: delete 1 | |||
| || Clears address book permanently. | |||
| || Example: clear | |||
| || find: Finds all persons whose names contain any of the specified keywords (case-sensitive) and displays them as a list with index numbers. | |||
| || find: Finds all persons whose names contain any of the specified keywords (NON case-sensitive) and displays them as a list with index numbers. | |||
| @@ -238,7 +238,7 @@ private int parseArgsAsDisplayedIndex(String args) throws ParseException, Number | |||
| * @return the prepared command | |||
| */ | |||
| private Command prepareFind(String args) { | |||
| final Matcher matcher = KEYWORDS_ARGS_FORMAT.matcher(args.trim()); | |||
| final Matcher matcher = KEYWORDS_ARGS_FORMAT.matcher(args.toUpperCase().trim()); | |||
pls comment need class part thx