Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113T-T12-2] PayMeBack #31

Open
wants to merge 832 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
832 commits
Select commit Hold shift + click to select a range
b38f3a4
fix bug where no delete index defaults to delete trip error
yeezao Nov 4, 2021
ece2718
reposense ownership claims
yeezao Nov 4, 2021
4d3921a
fix checkstyle
yeezao Nov 4, 2021
751879e
Merge pull request #245 from yeezao/v2.1/bugs1
lixiyuan416 Nov 5, 2021
917fb2c
Javadocs
Nov 5, 2021
5910b70
Fix help command, update UG, add PPP
lixiyuan416 Nov 5, 2021
e9c03f7
Fix checkstyle
lixiyuan416 Nov 5, 2021
24f03e1
^
lixiyuan416 Nov 5, 2021
78816cd
Merge pull request #246 from joshualeeky/v2.0-WorkingBranch
leeyikai Nov 5, 2021
41e0bba
Fix small typo
lixiyuan416 Nov 6, 2021
d6153fd
Merge pull request #248 from lixiyuan416/final-iteration
lixiyuan416 Nov 6, 2021
2cd0f29
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into upd…
leeyikai Nov 6, 2021
d3ab8a0
Final touches and updates (UG had some glaring problems)
itsleeqian Nov 6, 2021
bae3243
txt files updated
itsleeqian Nov 6, 2021
e9c343d
checkstyle error
itsleeqian Nov 6, 2021
c5d8b4f
Added JavaDocs for filter function and optimize function
leeyikai Nov 6, 2021
cca6bf4
Edited to fix checkstyle
leeyikai Nov 6, 2021
530caa0
Merge pull request #249 from itsleeqian/v2.1/finalUpdates
yeezao Nov 6, 2021
3b89b5f
update ppp (yeezao.md)
yeezao Nov 6, 2021
5f6b666
update ppp (yeezao.md)
yeezao Nov 6, 2021
147dfbd
Merge pull request #250 from leeyikai/update/java-docs
yeezao Nov 6, 2021
22b538d
Merge branch 'master' into v2.1/bugs1
yeezao Nov 6, 2021
4b933d6
update reposense ownership claims
yeezao Nov 6, 2021
57345ce
update UserGuide.md
yeezao Nov 6, 2021
b79ef82
update UserGuide.md
yeezao Nov 6, 2021
6a3a195
fix edit trip bug (excessive regex splitting)
yeezao Nov 6, 2021
d6b8935
add trip tests (new trip and edit trip)
yeezao Nov 6, 2021
ef42682
fix checkstyle
yeezao Nov 6, 2021
ded548b
change command classes to non-abstract
yeezao Nov 6, 2021
e1ec762
Revert "change command classes to non-abstract"
yeezao Nov 6, 2021
67f594e
fix checkstyle
yeezao Nov 6, 2021
2743014
Minor changes to Ui
Nov 6, 2021
3e8c609
Merge branch 'master' of https://github.com/AY2122S1-CS2113T-T12-2/tp…
Nov 6, 2021
3e2b65b
add more trip tests
yeezao Nov 6, 2021
f156f26
Merge pull request #251 from yeezao/v2.1/bugs1
itsleeqian Nov 6, 2021
73d2104
Added some tests
Nov 6, 2021
e57e5a7
Checkstyle
Nov 6, 2021
a3d8a04
Test error resolved
Nov 6, 2021
1da9282
IO redirection resolved
Nov 6, 2021
eb68f35
add tests for Trip, and minor bug fixes.
yeezao Nov 6, 2021
69e087d
fix checkstyle and add more tests
yeezao Nov 6, 2021
cd4b77d
fix checkstyle
yeezao Nov 6, 2021
ee4a744
Merge pull request #252 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 6, 2021
39276b6
update javadoc
yeezao Nov 6, 2021
ffadeea
Added setter for expense
leeyikai Nov 6, 2021
d26f1b4
Added tests for optimizer (WIP)
leeyikai Nov 6, 2021
ac6235b
Merge pull request #253 from yeezao/v2.1/bugs1
lixiyuan416 Nov 7, 2021
4dca363
Merge branch 'master' into v2.1/finalUpdates
itsleeqian Nov 7, 2021
c18343f
Update DG headers to match requirements, fix README, AboutUs
lixiyuan416 Nov 7, 2021
81676ae
Forgot to stage files
lixiyuan416 Nov 7, 2021
9ab966d
Merge pull request #255 from lixiyuan416/DG-headers
itsleeqian Nov 7, 2021
7b050ab
Added puml files for my DG updates
itsleeqian Nov 7, 2021
13fe163
Merge branch 'master' into v2.1/finalUpdates
itsleeqian Nov 7, 2021
049ffdd
Update my PPP
lixiyuan416 Nov 7, 2021
7b4d23b
added the style and color files for PUML work
itsleeqian Nov 7, 2021
6ba4fab
Updated test files
leeyikai Nov 7, 2021
7b73641
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into upd…
leeyikai Nov 7, 2021
97ff228
Merge pull request #256 from itsleeqian/v2.1/finalUpdates
leeyikai Nov 7, 2021
6e714b6
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into upd…
leeyikai Nov 7, 2021
1405393
Update Javadoc
lixiyuan416 Nov 7, 2021
fc1a506
update trip tests (for duplicate trips)
yeezao Nov 7, 2021
5c59ecc
Add -cancel to command summary in UG
lixiyuan416 Nov 7, 2021
c9719eb
initial DG commits (colors and stuff not super finalised)
itsleeqian Nov 7, 2021
820acb0
Merge pull request #257 from itsleeqian/v2.1/finalUpdates
joshualeeky Nov 7, 2021
d6acfe3
DG first draft
Nov 7, 2021
fdd0de6
Merge pull request #258 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 7, 2021
69ec1e2
Add more junit tests, change all interfaces to public from a mix of p…
lixiyuan416 Nov 7, 2021
1c5aa8c
Fix checkstyle
lixiyuan416 Nov 7, 2021
fa83d1b
add diagrams and update text for DeveloperGuide.md (Storage component)
yeezao Nov 7, 2021
5922050
Merge pull request #259 from lixiyuan416/tests-ppp
itsleeqian Nov 7, 2021
84906e6
Merge pull request #260 from yeezao/v2.1/docs+tests
itsleeqian Nov 7, 2021
e096035
Merge branch 'master' into v2.1/docs+tests
yeezao Nov 7, 2021
968a59e
Added tests for expense
Nov 7, 2021
f67bb36
Merge branch 'master' into v2.0-WorkingBranch
joshualeeky Nov 7, 2021
8183a79
Merge branch 'master' of https://github.com/AY2122S1-CS2113T-T12-2/tp…
Nov 7, 2021
4f3b568
Resolved merge conflicts
Nov 7, 2021
d00cf84
Merge remote-tracking branch 'origin/v2.0-WorkingBranch' into v2.0-Wo…
Nov 7, 2021
41576d8
Resolved merge conflicts
Nov 7, 2021
c4cf096
Resolved test error
Nov 7, 2021
b299ccb
userguide error resolved
Nov 7, 2021
a2f236d
Delete MANIFEST.MF
joshualeeky Nov 7, 2021
228f90e
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into upd…
leeyikai Nov 7, 2021
ef2eee7
Small UserGuide updates
Nov 7, 2021
ed8b8cf
Merge remote-tracking branch 'origin/v2.0-WorkingBranch' into v2.0-Wo…
Nov 7, 2021
35e4491
Class diagram edit
Nov 7, 2021
6acd73a
Merge pull request #261 from joshualeeky/v2.0-WorkingBranch
itsleeqian Nov 7, 2021
9bb60f0
add diagrams and update text for DeveloperGuide.md (Trip class)
yeezao Nov 7, 2021
4e3e95e
change userInputDateError() from public to private
yeezao Nov 7, 2021
48f4b5f
change visiblity of some methods
yeezao Nov 7, 2021
dafefb3
Added diagrams and explanation
leeyikai Nov 7, 2021
4d707b6
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into upd…
leeyikai Nov 7, 2021
13ea2d4
Merge pull request #262 from yeezao/v2.1/docs+tests
leeyikai Nov 7, 2021
99143fa
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into upd…
leeyikai Nov 7, 2021
1232c56
Added more tests for Expenses
Nov 8, 2021
4ae7376
Merge pull request #263 from leeyikai/update/add-diagrams-DG
joshualeeky Nov 8, 2021
4bf4295
Checkstyle
Nov 8, 2021
3088d45
Update DG Ui, fixed typo in edit -exchangerate, update PPP, improve e…
lixiyuan416 Nov 8, 2021
5e65219
Merge branch 'master' into dg-and-bugfixes
lixiyuan416 Nov 8, 2021
4204327
Merge pull request #264 from joshualeeky/v2.0-WorkingBranch
lixiyuan416 Nov 8, 2021
afe847d
Checkstyle
lixiyuan416 Nov 8, 2021
4b30fd5
Merge pull request #265 from lixiyuan416/dg-and-bugfixes
joshualeeky Nov 8, 2021
7b832ef
MOREEE TESTTSSS
Nov 8, 2021
cedabb6
Added current date test
Nov 8, 2021
6640513
Update DG appendixes
lixiyuan416 Nov 8, 2021
8a4553e
Resolved negative number bug when assigning amounts in expenses
Nov 8, 2021
0d0bbac
Added more tests for expense.
Nov 8, 2021
f607102
Resolves test errors
Nov 8, 2021
1bda179
Merge pull request #266 from joshualeeky/v2.0-WorkingBranch
leeyikai Nov 8, 2021
2a6dcbb
Slight update to UGDG
Nov 8, 2021
5ba8721
Merge branch 'master' into feat/add-junit
leeyikai Nov 8, 2021
364c7d9
Edited checkstyle
leeyikai Nov 8, 2021
849ad16
Merge pull request #267 from leeyikai/feat/add-junit
itsleeqian Nov 8, 2021
99a04d4
Update DG Trip sequence diagram
lixiyuan416 Nov 8, 2021
6f3ebf5
Merge branch 'master' into last-branch
lixiyuan416 Nov 8, 2021
3df7ee3
PPP update
lixiyuan416 Nov 8, 2021
f84993e
Merge pull request #268 from lixiyuan416/last-branch
itsleeqian Nov 8, 2021
714de85
Slight UG update
Nov 8, 2021
0285941
UG grammar fix
Nov 8, 2021
647fda3
DG edit
Nov 8, 2021
2e0d939
DG diagram check
lixiyuan416 Nov 8, 2021
7260ecd
Update PPP
leeyikai Nov 8, 2021
3f1fc94
Merge branch 'master' into feat/add-view-tests
leeyikai Nov 8, 2021
a90ceb8
Merge pull request #270 from leeyikai/feat/update-PPP
joshualeeky Nov 8, 2021
a9fb34f
Merge pull request #269 from joshualeeky/v2.0-WorkingBranch
leeyikai Nov 8, 2021
77eff87
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into fea…
leeyikai Nov 8, 2021
d93284c
Doc check 1
lixiyuan416 Nov 8, 2021
8dbcbb1
Add trip class diagrams
lixiyuan416 Nov 8, 2021
01e0205
Add Robin Hood
lixiyuan416 Nov 8, 2021
a90c95c
Removed trip class diagrams
lixiyuan416 Nov 8, 2021
4f8ef22
Merge pull request #271 from lixiyuan416/last-last
yeezao Nov 8, 2021
805adbd
Add puml trip class diagram
lixiyuan416 Nov 8, 2021
f91abb0
Merge pull request #272 from lixiyuan416/Stonks
yeezao Nov 8, 2021
c030c69
Merge branch 'master' into v2.1/docs+tests
yeezao Nov 8, 2021
b466cf0
update yeezao.md (ppp) + ReadFromFileSeqDiag.puml
yeezao Nov 8, 2021
56131df
update ReadFromFileSeqDiag.puml
yeezao Nov 8, 2021
15dcd8b
update yeezao.md (ppp)
yeezao Nov 8, 2021
4bb5310
Added tests for view function
leeyikai Nov 8, 2021
0a52833
Merge remote-tracking branch 'AY2122S1-CS2113T-T12-2/master' into fea…
leeyikai Nov 8, 2021
4e34264
Edited to fix checkstyle
leeyikai Nov 8, 2021
eeec27e
Merge pull request #274 from leeyikai/feat/add-view-tests
joshualeeky Nov 8, 2021
9c95fd3
Bugfix expense date
lixiyuan416 Nov 8, 2021
53839ad
Merge branch 'v2.1/bugs1' into v2.1/docs+tests
yeezao Nov 8, 2021
a2e80ed
Merge pull request #275 from lixiyuan416/final-bugfix-expense-date
joshualeeky Nov 8, 2021
5758fc4
Added test code for foreign currency stuff and summary
itsleeqian Nov 8, 2021
0eb02be
Merge branch 'master' into v2.1/finalUpdates
itsleeqian Nov 8, 2021
b084f7d
updated PPP
itsleeqian Nov 8, 2021
1721bbe
Merge pull request #273 from yeezao/v2.1/docs+tests
itsleeqian Nov 8, 2021
ab2ab0f
Merge branch 'master' into v2.1/finalUpdates
itsleeqian Nov 8, 2021
bc14608
update UG, PPP, add tests and fix bugs
yeezao Nov 8, 2021
0572548
removed glossary (no complicated words to define) and updates to PPP
itsleeqian Nov 8, 2021
82166a2
update NFR in DeveloperGuide.md
yeezao Nov 8, 2021
026f29d
Merge pull request #276 from itsleeqian/v2.1/finalUpdates
yeezao Nov 8, 2021
8b424af
Expense Class tests
Nov 8, 2021
ebc6a06
Merge branch 'master' into v2.1/docs+tests
yeezao Nov 8, 2021
28d4e12
update TripTest and PPP (yeezao.md)
yeezao Nov 8, 2021
53d1a69
Merge pull request #278 from joshualeeky/v2.0-WorkingBranch
itsleeqian Nov 8, 2021
a85a6c2
fix checkstyle
yeezao Nov 8, 2021
6917217
Merge pull request #277 from yeezao/v2.1/docs+tests
itsleeqian Nov 8, 2021
0eb2414
Small documentation updates
Nov 8, 2021
0fdf3bf
Small documentation updates
Nov 8, 2021
f081d95
fix bug in storage comp class diag
yeezao Nov 8, 2021
6f13fe3
minor fix in UG, add manual testing for trips in DG.
yeezao Nov 8, 2021
00847b3
update ppp
yeezao Nov 8, 2021
0630e97
update ppp and dg for FileStorage implementation
yeezao Nov 8, 2021
d275703
update ppp
yeezao Nov 8, 2021
c3e1d29
Merge pull request #279 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 8, 2021
82d27ab
Update PPP
leeyikai Nov 8, 2021
5b3a539
Merge pull request #281 from leeyikai/feat/update-PPPv2
yeezao Nov 8, 2021
91f5442
update code style
yeezao Nov 8, 2021
54e17db
Update lixiyuan416.md
lixiyuan416 Nov 8, 2021
9205b18
update code style
yeezao Nov 8, 2021
0da57ee
Merge pull request #280 from yeezao/v2.1/docs+tests
lixiyuan416 Nov 8, 2021
40849ef
update code style
yeezao Nov 8, 2021
63349eb
Merge pull request #282 from AY2122S1-CS2113T-T12-2/lixiyuan416-patch-1
yeezao Nov 8, 2021
31e94d9
Added javadocs for Expense and Trip legacy constructors
leeyikai Nov 8, 2021
745440b
update UG (deleting and listing)
yeezao Nov 8, 2021
3f963f5
Removed magic numbers for Expense constructor
leeyikai Nov 8, 2021
c8cb614
update UG (FAQ)
yeezao Nov 8, 2021
2acccf4
Removed magic number and string for executeView
leeyikai Nov 8, 2021
71e4d6e
refactor "y" and "n" to Ui
yeezao Nov 8, 2021
31ea7ce
Updated PPP grammer
leeyikai Nov 8, 2021
a15d47b
Merge pull request #283 from leeyikai/feat/update-overall
itsleeqian Nov 8, 2021
b78cecc
Updated picture in readme
leeyikai Nov 8, 2021
d9500ed
update UG
yeezao Nov 8, 2021
715acca
Merge pull request #285 from leeyikai/feat/update-overall
joshualeeky Nov 8, 2021
e9cbb6b
Merge branch 'master' into v2.1/docs+tests
yeezao Nov 8, 2021
8f0216f
Merge pull request #284 from yeezao/v2.1/docs+tests
yeezao Nov 8, 2021
cfb0d67
Updated profile picture
leeyikai Nov 8, 2021
7b44422
Trip diagram changes
lixiyuan416 Nov 8, 2021
56be89a
Updated yuzhao image
leeyikai Nov 8, 2021
47ac179
added line
itsleeqian Nov 8, 2021
049342d
Updated profile picture resolution
leeyikai Nov 8, 2021
3a34a22
Merge branch 'master' into v2.1/finalUpdates
itsleeqian Nov 8, 2021
7a05996
update UG
yeezao Nov 8, 2021
5e8ddbf
Merge pull request #287 from yeezao/v2.1/docs+tests
yeezao Nov 8, 2021
2f5413f
Merge pull request #286 from lixiyuan416/fff
itsleeqian Nov 8, 2021
90446bc
Merge pull request #288 from itsleeqian/v2.1/finalUpdates
lixiyuan416 Nov 8, 2021
79bd7c8
remove Gson custom (de)serialiser code snippet
yeezao Nov 8, 2021
fab093c
Merge pull request #289 from leeyikai/feat/update-overall
yeezao Nov 8, 2021
8229f6d
Merge pull request #290 from yeezao/v2.1/docs+tests
yeezao Nov 8, 2021
117e4d3
PPP update
Nov 8, 2021
0d57a91
Merge pull request #291 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 8, 2021
b213551
User Stories
lixiyuan416 Nov 8, 2021
21b7be3
Fix typo
lixiyuan416 Nov 8, 2021
69e4c7e
^
lixiyuan416 Nov 8, 2021
640fbf1
update ppp
yeezao Nov 8, 2021
3e693ad
Merge pull request #292 from lixiyuan416/user-stories
yeezao Nov 8, 2021
6d16aa1
Merge pull request #293 from yeezao/v2.1/docs+tests
yeezao Nov 8, 2021
44c68f7
PPP update
Nov 8, 2021
6f8f4c1
Merge pull request #294 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 8, 2021
fa2b91b
update ppp
yeezao Nov 8, 2021
6cf773b
Merge pull request #295 from yeezao/v2.1/docs+tests
yeezao Nov 8, 2021
bd1c572
update ppp
yeezao Nov 8, 2021
2cc02ed
Merge pull request #296 from yeezao/v2.1/docs+tests
yeezao Nov 8, 2021
1880555
PPP update
Nov 8, 2021
03ea6bc
added manual testing for edit trip and view summary
itsleeqian Nov 8, 2021
d00c305
Add man-testing
lixiyuan416 Nov 8, 2021
8c9aa6e
Merge branch 'master' into v2.1/finalUpdates
itsleeqian Nov 8, 2021
ec7ccdd
Merge pull request #297 from lixiyuan416/man-testing
itsleeqian Nov 8, 2021
c71e578
Merge branch 'master' into v2.1/finalUpdates
lixiyuan416 Nov 8, 2021
0a5a184
Merge pull request #298 from itsleeqian/v2.1/finalUpdates
lixiyuan416 Nov 8, 2021
41621b8
Update PPP
leeyikai Nov 8, 2021
603bc67
Merge pull request #299 from leeyikai/feat/update-overall
yeezao Nov 8, 2021
64281c0
Fixed spacing
leeyikai Nov 8, 2021
bc0f1ca
Merge pull request #300 from leeyikai/feat/update-overall
yeezao Nov 8, 2021
45f98c4
update
itsleeqian Nov 8, 2021
f9cd37e
Merge branch 'master' into v2.1/finalUpdates
itsleeqian Nov 8, 2021
100aa27
DG update.
Nov 8, 2021
ea9183c
Merge branch 'master' of https://github.com/AY2122S1-CS2113T-T12-2/tp…
Nov 8, 2021
38c777b
Merge pull request #301 from itsleeqian/v2.1/finalUpdates
yeezao Nov 8, 2021
9a636c8
Updated PPP
leeyikai Nov 8, 2021
d659d8a
Merge pull request #302 from leeyikai/feat/update-overall
yeezao Nov 8, 2021
7452419
Updated PPP
leeyikai Nov 8, 2021
2e74c27
Merge pull request #303 from leeyikai/feat/update-overall
yeezao Nov 8, 2021
9a261af
DG update.
Nov 8, 2021
4967fb2
Merge pull request #304 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 8, 2021
ba7e77f
DG update.
Nov 8, 2021
12ffc8b
DG update.
Nov 8, 2021
628b4f1
Merge pull request #305 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 8, 2021
4bb095b
DG update.
Nov 8, 2021
0b72e18
Merge pull request #306 from joshualeeky/v2.0-WorkingBranch
yeezao Nov 8, 2021
67c4988
Update UserGuide.md
yeezao Nov 12, 2021
3445567
Update UserGuide.md
yeezao Nov 12, 2021
25091de
Update UserGuide.md
yeezao Nov 12, 2021
bfd9244
Update UserGuide.md
yeezao Nov 12, 2021
060a243
Update UserGuide.md
yeezao Nov 12, 2021
efe8ccb
Update UserGuide.md
yeezao Nov 12, 2021
9ab3d6e
Update UserGuide.md
yeezao Nov 12, 2021
3f407a9
Update UserGuide.md
yeezao Nov 12, 2021
82e898b
Update UserGuide.md
yeezao Nov 12, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report--customised-template-.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
name: Bug report (Customised Template)
about: Template to provide bug reports
title: ''
labels: type.Bug
assignees: ''

---

**Bug Description**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

**Expected behavior**
A clear and concise description of what you expected to happen.

**Actual Behaviour**
Provide any output of what actually happened, and the stack trace if possible.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report--github-template-.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
name: Bug report (Github Template)
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
10 changes: 10 additions & 0 deletions .github/ISSUE_TEMPLATE/user-stories.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
name: User Stories
about: Blank template (with some tags set) for adding new user stories
title: ''
labels: type.Story
assignees: ''

---


2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ bin/

/text-ui-test/ACTUAL.txt
text-ui-test/EXPECTED-UNIX.TXT
src/main/java/seedu/duke/Mytest.java
trips.json
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,5 @@ Steps for publishing documentation to the public:
1. Scroll down to the `GitHub Pages` section.
1. Set the `source` as `master branch /docs folder`.
1. Optionally, use the `choose a theme` button to choose a theme for your documentation.

*temp change*
Binary file added Resources/Expense Sequence Diagram.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ repositories {
dependencies {
testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter-api', version: '5.5.0'
testRuntimeOnly group: 'org.junit.jupiter', name: 'junit-jupiter-engine', version: '5.5.0'
implementation group: 'com.google.code.gson', name: 'gson', version: '2.8.8'
}

test {
Expand Down Expand Up @@ -41,6 +42,7 @@ checkstyle {
toolVersion = '8.23'
}

run{
run {
standardInput = System.in
enableAssertions = true
}
11 changes: 6 additions & 5 deletions docs/AboutUs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

Display | Name | Github Profile | Portfolio
--------|:----:|:--------------:|:---------:
![](https://via.placeholder.com/100.png?text=Photo) | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)

![](https://via.placeholder.com/100.png?text=Photo) | Lee Yi Kai | [Github](https://github.com/leeyikai) | [Portfolio](docs/team/leeyikai.md)
![](https://via.placeholder.com/100.png?text=Photo) | Xi Yuan | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Lee Keng Yong Joshua | [Github](https://github.com/joshualeeky) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Lee Qi An | [Github](https://github.com/itsleeqian) | [Portfolio](docs/team/qian.md)
![](https://via.placeholder.com/100.png?text=Photo) | Liang Yuzhao | [Github](https://github.com/yeezao) | [Portfolio](docs/team/johndoe.md)
86 changes: 83 additions & 3 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,91 @@

## Acknowledgements
Comment on lines 2 to 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding hyperlinks to subtopics would be a great idea! (like content pointers used in UG)


{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}
Third party library used: GSON under Apache License 2.0

## Design & implementation

{Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}
## Design

### Architecture
The ***Architecture Diagram*** given above explains the high-level design of the App.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagram remained to be finished

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I agree, better to have atleast a few class diagrams


Given below is a quick overview of main components and how they interact with each other.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add an object diagram here to show how the classes interact with one another

**Main components of the architecture**

`Main` is responsible for initialising the different components correctly at app launch, and connecting them with one another.

`Commons` represents a collection of classes used by multiple components.
The major classes in `Commons` are `Trip`, `Expense` and `Person`.
Further elaboration on these classes will be in the following sections later.

The remaining components are as follows:

`Ui`: The User Interface of the App
`Parser`: The command executor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having line breaks here may improve your DG as it makes the DG more readable and easier to understand, and it will be slightly less cluttered.

`Storage`: Holds the data of the App in memory, and also reads and writes data to the hard disk

**How the architecture components interact with one another**

The ***Sequence Diagram*** below shows how the components interact with each other.
For this particular interaction, the user has issued the command
`create` with the correct input parameters.

The sections below provide more details of the components and classes in them.


### `Trip` Class

The `Trip` class contains attributes storing the details of trips added by the user,
and is a container class for the expenses (each expense being represented by an
instance of the `Expense` class) and persons (each person being represented by an
instance of the `Person` class) tagged to the trip.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the Trip class contains many other classes and constructors of the other classes, would a UML diagram here help with the clarity of your DG?

A trip is created when the `Parser` class calls its `executeCreate()` method to instantiate
a new instance of `Trip`. The newly-created trip is then added to the `ArrayList<Trip>`
in the Storage class

Although the program is able to store zero trips, in order for it to work at any appreciable level,
there must be at least one trip added by the user (either through input or through loading from the
save file) in order for any other features to be available. If there are no trips added, the program
will repeatedly prompt the user to add a new trip.

### `Person` Class
The Person Class,
* Represents an individual that participated in an expense or a whole trip.
* A user-defined amount of `Person` objects will be created by the user during the create function of the `Trip` Class.
* Every time an object is created of the `Expense` Class, the user may define the people who were involved in the expense, however the people who are added to the expense must be already a `Person` object in the `Trip` object that the expense was made.
* One `Person` object who was involved in the expense will then be appointed as the payer of the group, the user will then have to indicate how much (in foreign currency) each of the participating persons spent for that particular expense. This is then stored and updated in each of the respective `Person` object’s `moneyOwed` HashMap, where a positive double refers to how much the person owes the respective Person object (i.e. the key of the HashMap) and a negative double refers to how much the Person object (i.e. the key of the HashMap) owes to that instance of the Person object.
* Example: If the HashMap = {person2 = 22, person3 = -11} in the person1 object, then person1 owes person2 $22 and person3 owes person1 $11.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a fellow developer, I would like to recommend that the description for each your classes could follow a standard format. This would help the reader easily understand the idea/explanations of the concepts.


### `Ui` Class

The `Ui` class handles everything that the user sees, which includes exception handling messages, outputs to users and feedback.

`Ui` class consists of multiple print methods, where some are listed above in the UML diagram. `Ui` depends on other classes,
such as `Storage`, `Parser`, `Trip` and `Expense` to obtain information stored in these classes.

The `Ui` class,
- Obtains information from Storage, Parser, Trip and Expense components.
- Prints the information through the terminal.

### `Parser` Class

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A UML class diagram would be helpful here to show the associations used for each command being called here.

The `Parser` class handles all input and executes the corresponding actions based on the user input.
It consists of methods that will execute most commands that is crucial to the functionality of our program.

`Parser` depends on other classes for the respective inputs and outputs.`Duke` calls the `Parser` class in order for the
necessary commands to be executed. However, not all functionality is stored here. Rather, `Parser` acts like an interface
that handles all the logic required to pass in the correct information into the different classes to execute.

The `Parser` class
- Contains the logic to check user commands and break the input into the necessary contents for other classes to use
Copy link

@KishorKumar11 KishorKumar11 Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, documentations like this can be followed for the other classes too?


### `Expense` Class
The `Expense` class deals with most functionalities related to adding an expense inside a trip. The sequence diagram below shows how an expense is initialised.
![](../Resources/Expense%20Sequence%20Diagram.jpeg)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to view sequence diagram. Perhaps you could recheck the directory/link?


When `Parser` calls the `executeExpense` method, it creates an expense object, and also calls the `promptDate` method to set that expense object’s date. `promptDate` calls `isDateValid` to validate user input.


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some in this part?

## Product scope
Expand Down
Loading