[bryanongjx] iP #379

bryanongjx · 2023-02-01T10:35:09Z

Tick Pro

"For every minute spent organising, an hour is earned" - Tick from Brawl Stars

"Tick OP" - every salty brawl stars player

Tick Pro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to learn

Setting it up

download Tick Pro (v0.2) from here
double-click it
add your tasks
let it manage tasks for you 😉

and it's FREE!! 🤑

Features:

Managing tasks
Managing deadlines
Reminders (coming soon)

If you are a java programmer, you can use it to practice java too. Here's
the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

This reverts commit e2dc23c.

rmj1405

Overall no major code style violations. After tidying up the long lines, you are good to go!

rmj1405 · 2023-02-01T17:17:40Z

src/main/java/Duke.java

@@ -1,10 +1,83 @@
+import java.util.*;


According to the coding standard, you may want to list all imports explicitly as they make the class easier to read 😀

rmj1405 · 2023-02-01T17:19:00Z

src/main/java/Duke.java

+        System.out.println("Hello! I'm Duke\n");
+        System.out.println("What can I do for you?\n");
+
+        List<Task> lst = new ArrayList<>();


Nice naming, easy to understand in subsequent code 👍

rmj1405 · 2023-02-01T17:21:35Z

src/main/java/Duke.java

+                    String details = actionAndDetails[1];
+                    Todo newTodo = new Todo(details);
+                    lst.add(newTodo);
+                    System.out.println("Got it. I've added this task:" + '\n' + newTodo + '\n' + "Now you have " + lst.size() + " tasks in the list");


This line may be exceeding the 120 character limit, perhaps you would like to double check!

rmj1405 · 2023-02-01T17:22:13Z

src/main/java/Duke.java

+                    lst.remove(taskNum - 1);
+                    System.out.println("Noted. I've removed this task:" + '\n' + currTask  + '\n' + "Now you have " + lst.size() + " tasks in the list");
+                }else {
+                    throw new DukeException("OOPS!!! I'm sorry, but I don't know what that means :-(");


Cute emoji 😄

antonlee59

Overall, LGTM. Good job on completing up to Level 6. All the best for the upcoming weeks.

antonlee59 · 2023-02-04T21:46:06Z

src/main/java/Event.java

+    String From;
+    String To;
+    public Event(String description, String From, String To) {


Perhaps, the naming of the fields can follow the norm of the 'description' field with small letters instead of capitalised ones. I think as long as you are consistent, it should be fine

antonlee59 · 2023-02-04T21:47:29Z

src/main/java/Duke.java

+                if (action.equals("bye")) {
+                    System.out.println("Bye. Hope to see you again soon!");
+                    return;
+                } else if (action.equals("list")) { // list
+                    System.out.println("Here are the tasks in your list:");
+                    for (int i = 1; i <= lst.size(); i++) {
+                        System.out.println(i + ". " + lst.get(i - 1));
+                    }
+                } else if (action.equals("mark")) {
+                    String details = inputArr[1];
+                    int taskNum = Integer.parseInt(details);
+                    Task currTask = lst.get(taskNum - 1);
+                    currTask.mark();
+                    System.out.println("Nice! I've marked this task as done" + '\n' + currTask);
+                } else if (action.equals("unmark")) {
+                    String details = inputArr[1];
+                    int taskNum = Integer.parseInt(details);
+                    Task currTask = lst.get(taskNum - 1);
+                    currTask.unMark();
+                    System.out.println("Nice! I've marked this task as not done yet" + '\n' + currTask);
+                } else if (action.equals("todo")) {


Perhaps, using a switch-case statement would make it slightly more readable.

This reverts commit cf92c42.

# Conflicts: # data/duke.txt # src/main/java/Duke.java

add assertions to TaskList methods

This reverts commit 4c1d6c5.

This reverts commit cb80e43.

update user guide

damithc and others added 9 commits July 31, 2022 17:20

Add Gradle support

556af3f

first commit

e2dc23c

Revert "first commit"

9db8e00

This reverts commit e2dc23c.

Level 1 Commit

20ce1ef

second commit

e948091

level 3 commit

89bdac5

Level 4 commit

7b40056

Level 5 Commit

81c9a07

Level 6 commit

7214d96

rmj1405 reviewed Feb 1, 2023

View reviewed changes

antonlee59 reviewed Feb 4, 2023

View reviewed changes

bryanongjxairetec and others added 19 commits February 6, 2023 18:20

Level 7 Commit

cf92c42

Revert "Level 7 Commit"

5a3100f

This reverts commit cf92c42.

added date feature

58a445a

Merge branch 'branch-Level-8'

4f6015e

# Conflicts: # data/duke.txt # src/main/java/Duke.java

Added classes Parser, Storage, TaskList and Ui

1b62400

Moved classes to a single packed "duke"

7f63b95

Merge remote-tracking branch 'origin/add-gradle-support'

a3e7ddd

Add gradle files

3b342e4

add JUnit Testing (for addition of todo, events and deadlines)

66cf005

Added java docs

7304d67

Merge branch 'branch-A-JavaDoc'

8149068

Edit code to comply with java coding standard

a751546

add Find feature to locate tasks by keyword

a4305f5

add image of tick for readme

75434c3

Update README.md

d0ee74a

add GUI using JavaFX

89cb4cb

Merge branch 'master' of https://github.com/bryanongjx/ip

9a048bb

add assertions to TaskList methods: getTaskList & findTask

6b62d7c

Merge pull request #2 from bryanongjx/branch-A-Assertions

281887a

add assertions to TaskList methods

bryanongjx and others added 21 commits February 16, 2023 23:52

amend storage methods for cleaner code quality

ec4f38b

Improve code quality by abstracting out parser commands

125a1ba

corrected bugs from previous commit of improving code quality

54966ee

improve GUI

4c1d6c5

Revert "improve GUI"

cb80e43

This reverts commit 4c1d6c5.

Revert "Revert "improve GUI""

9773ae4

This reverts commit cb80e43.

add screenshot for user guide

abc3980

update user guide

61ba68b

update user guide

minor fixes

8ce8ade

add text ui test

ec6df17

reset user guide

56e199b

add user guide with set up instructions and feature usages

d0d6670

edit readme

c10b1b7

add image for user and duke

9625384

rename and move Ui screenshot

3a259b7

rename and move ui screenshot

0d4c3b6

edit directory link of user guide screenshot

5df8906

fix format of user guide

c490000

fix format of user guide

76ab484

fixed format of userguide

2bdc84d

fixed format of user guide

9b15285

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bryanongjx] iP #379

[bryanongjx] iP #379

bryanongjx commented Feb 1, 2023 •

edited

Loading

rmj1405 left a comment

rmj1405 Feb 1, 2023

rmj1405 Feb 1, 2023

rmj1405 Feb 1, 2023

rmj1405 Feb 1, 2023

antonlee59 left a comment

antonlee59 Feb 4, 2023

antonlee59 Feb 4, 2023

[bryanongjx] iP #379

Are you sure you want to change the base?

[bryanongjx] iP #379

Conversation

bryanongjx commented Feb 1, 2023 • edited Loading

Tick Pro

Setting it up

rmj1405 left a comment

Choose a reason for hiding this comment

rmj1405 Feb 1, 2023

Choose a reason for hiding this comment

rmj1405 Feb 1, 2023

Choose a reason for hiding this comment

rmj1405 Feb 1, 2023

Choose a reason for hiding this comment

rmj1405 Feb 1, 2023

Choose a reason for hiding this comment

antonlee59 left a comment

Choose a reason for hiding this comment

antonlee59 Feb 4, 2023

Choose a reason for hiding this comment

antonlee59 Feb 4, 2023

Choose a reason for hiding this comment

bryanongjx commented Feb 1, 2023 •

edited

Loading