[Cheng Deren] iP #367

DerenC · 2023-01-30T22:21:19Z

Wessy, your friendly neighbourhood personal assistant

What I cannot do:

Take your trash out
Eat your vege
Do your homework

What I can do:

Help you keep track of the task you need to do
Help you keep track of the event you need to attend
Help you keep track of upcoming deadlines

I can even print hello world, just like you.

class Main {
    public static void main(String[] args) {
        System.out.println("Hello World");
    }
}

What you should do everyday:

Greet me every morning.
Use me more and more 😏
Say goodbye to me every night.

~~BEND DOWN TO ME, YOU LOWLY HUMAN~~

"Wubba Lubba Dub Dub" ~ Rick Sanchez (source)

seriouslia0

Overall LGTM

seriouslia0 · 2023-02-03T11:27:13Z

src/main/java/Wessy.java

@@ -89,6 +92,42 @@ static String[] parse(String description, CmdType type) throws
        return new String[] {};
    }

+    static LocalDateTime parseDateTime(String str) {


Might want to store this parser into a seperate class

seriouslia0 · 2023-02-03T11:29:47Z

src/main/java/Wessy.java

+            System.out.println("   |   " + str.substring(0, 64) + "   |");
+            int remainingLength = length - 64;
+            int leftover = remainingLength % 62;
+            int n = (int) Math.floor(remainingLength/62);


Might want to split this function into several to make it easier to edit in the future.

wpx12011

Good job for following the coding standard closely! Perhaps can implement a Parser class to reduce the amount of contents in the Wessy class.

wpx12011 · 2023-02-05T15:39:23Z

src/main/java/Deadline.java

@@ -0,0 +1,32 @@
+import java.time.LocalDateTime;
+
+public class Deadline extends Task {


Perhaps can put this class into a package (like package duke), as other developers could better understand the code base when all the classes have been grouped in packages

wpx12011 · 2023-02-05T15:42:04Z

src/main/java/Wessy.java

@@ -0,0 +1,397 @@
+import Exceptions.CommandNotFoundException;


Great job on importing the classes explicitly, and ordered them in a logical way.

…) methods in Parser

These classes are: Parser UserInputChecker CmdType Task ToDo Deadline Event WessyException CommandNotFoundException MissingSpacingException TimeSpecifierException UnspecifiedTimeException EmptyListException InvalidIntegerException NotAnIntegerException NotPositiveIntegerException MissingInputException TooManyInputException

Use JavaFX technology to implement the GUI.

Refactor the whole code base by extracting out the closely related code as the following components, with their respective function * Parser -- Process user input. * Storage -- Retrieve from existing storage and save as a new file after every update. * Ui -- Handle I/O. * UserInputChecker -- Check and throw exceptions while checking for correct formatting in the user input. Rethink and recategorise the exceptions by merging those that seem closely related. Add TimeSpecifierException on tp of UnspecifiedTimeException to differentiate between the 2 exceptions. Create more packages. Rearrange the code by placing the relevant classes into their respective packages.

Use assert feature (not JUnit assertions) to document importaant assumptions that should hold at various points in the code.

Use the Streams feature of Java in my code, if applicable.

Use Streams

Use Assertions

Improve code quality

Implement the following 2 features: * B-DoAfterTasks * B-FixedDurationTasks

damithc and others added 16 commits July 31, 2022 17:20

Add Gradle support

556af3f

Add *.class to .gitignore

7412db5

Finish Level-1

5b4ad51

Finish Level-2

1986f7c

Change the chatbot's name from Duke to Wessy

2543b85

Improve the chatbot's opening message

fb30872

Increase indentation to improve the appearance of the displayed message

fc5d2f9

Create 'Task' class

fe4110b

Finish Level-3

c1d02c0

Finish Level-4

f2b385f

Clear up unused add functions

17205ad

Finish Level-5

d444660

Modify EXPECTED.TXT & input.txt

ba548a7

Finish Level-6

6ef4659

Use enumerations instead of strings in Wessy (main driver) class

6b4ecc8

Complete checkstyle based on CS2030's standard

da15bb8

This comment was marked as resolved.

Sign in to view

DerenC added 5 commits February 2, 2023 21:13

Finish Level-7

9cca35c

Finish Level-8

43e8e99

Merge branch 'branch-Level-7'

0e21ec3

Merge branch 'branch-Level-8'

72eb4cf

Merge remote-tracking branch 'remotes/origin/add-gradle-support'

551cf7b

seriouslia0 approved these changes Feb 3, 2023

View reviewed changes

Initial setup of Gradle

388ae95

wpx12011 reviewed Feb 5, 2023

View reviewed changes

DerenC added 5 commits February 9, 2023 09:20

Finish A-MoreOOP

4a61459

A-Packages

0a0f3f6

Add JUnit test to test getCmd(), parseDateTime(), removeSpacePadding(…

46e7bfe

…) methods in Parser

Create jar file for version release

88ec341

DerenC and others added 25 commits February 12, 2023 17:04

Finish A-CodingStandard

16f36ec

Finish Level-9

df037e7

Merge branch 'branch-Level-9'

a26aeeb

Merge branch 'branch-A-JavaDoc'

f8954a0

Merge branch 'branch-A-CodingStandard'

9ebbab9

Add a basic GUI to Wessy

98fa419

Use JavaFX technology to implement the GUI.

Rename methods in Ui from prints to gets

d387abf

Merge commit 'cd2818dd855ef73b919892fe0703f1bef09f8db5'

d40651d

Delete unnecessary java files outside the main.java.wessy directory

8431958

Use Assertions

432a76b

Use assert feature (not JUnit assertions) to document importaant assumptions that should hold at various points in the code.

Improve code quality

2a8e5da

Use Streams

0bedb08

Use the Streams feature of Java in my code, if applicable.

Merge pull request #4 from DerenC/branch-A-Streams

8da4963

Use Streams

Merge branch 'master' into branch-A-Assertions

ef63a64

Merge pull request #2 from DerenC/branch-A-Assertions

e9b5032

Use Assertions

Merge branch 'master' into branch-A-CodeQuality

ea08add

Merge pull request #3 from DerenC/branch-A-CodeQuality

370968f

Improve code quality

Delete commented-out code used for Ui in Wessy.java

6bfaf73

Declutter by deleting commented-out codes

bce0f40

Comment out System.in as standardInput

35838ce

Implemented 2 extensions from category B

8e57710

Implement the following 2 features: * B-DoAfterTasks * B-FixedDurationTasks

Add a User Guide

054a500

Minor correction on phrasing of descrption of Feature #3

09999ca

Second minor correction on phrasing of descrption of Feature #3

cda7911

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cheng Deren] iP #367

[Cheng Deren] iP #367

DerenC commented Jan 30, 2023 •

edited

Loading

This comment was marked as resolved.

seriouslia0 left a comment

seriouslia0 Feb 3, 2023

seriouslia0 Feb 3, 2023

wpx12011 left a comment

wpx12011 Feb 5, 2023

wpx12011 Feb 5, 2023

		@@ -0,0 +1,32 @@
		import java.time.LocalDateTime;

		public class Deadline extends Task {

		@@ -0,0 +1,397 @@
		import Exceptions.CommandNotFoundException;

[Cheng Deren] iP #367

Are you sure you want to change the base?

[Cheng Deren] iP #367

Conversation

DerenC commented Jan 30, 2023 • edited Loading

Wessy, your friendly neighbourhood personal assistant

This comment was marked as resolved.

seriouslia0 left a comment

Choose a reason for hiding this comment

seriouslia0 Feb 3, 2023

Choose a reason for hiding this comment

seriouslia0 Feb 3, 2023

Choose a reason for hiding this comment

wpx12011 left a comment

Choose a reason for hiding this comment

wpx12011 Feb 5, 2023

Choose a reason for hiding this comment

wpx12011 Feb 5, 2023

Choose a reason for hiding this comment

DerenC commented Jan 30, 2023 •

edited

Loading