Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truong Minh Duong] iP #366

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

Zhongli5712
Copy link

@Zhongli5712 Zhongli5712 commented Jan 30, 2023

Duke

It's not a bug; it's an undocumented feature. source.

Allows you to

  • Add new task
  • Mark/Unmark a task is done
  • Delete a task
  • Find a task

Type of tasks

  1. Todo task
  2. Deadline task
  3. Event task

Special features 🤠 :

  • Auto save and load previous task list
  • Print user-friendly syntax error
  • Motion avatar (comming soon)

For developer, can run the main method in Duke class:

public static void main(String[] args) {
        new Duke().run();
    }

Copy link

@WindyCall WindyCall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, not enough efforts put into CS2103T and not enough codes for review.
I will do the back up one instead.

Copy link

@kimberlybp kimberlybp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some minor coding standard issues, the code generally looks neat with good logic 👍🏼

Comment on lines 28 to 29
System.out.println("Nice! I've marked this task as done:");
System.out.println(todo_list.get(index-1));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can move System.out.println(..) into a function in your Ui class to utilise it more, since the purpose of the Ui class is to handle all interactions with the user

@@ -0,0 +1,12 @@
package duke;

public class DukeExceptions extends Exception{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the class name is valid according to coding standards, perhaps it would be more intuitive if it was named DukeException instead since it only represents an instance of 1 Exception

}

@Override
public void execute() throws DukeExceptions { todoList.mark(index); }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion✌🏼 Since the MarkCommand and UnmarkCommand classes do the same thing except the execute functions maybe you want to consider just using 1 class that handles all marking related commands with a check to determine whether to mark or unmark the task

System.out.println(task);
}

public int number_of_tasks() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding standards state the names representing methods must be written in camelCase, so i think getNumberOfTasks or numberOfTasks would be better

Comment on lines +132 to +133
String[] from_to_timeline = commands[1].split(" /to ");
if (from_to_timeline.length == 1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed some of your variable names use snake case, however the coding standards states that variable names must be in camelCase, so do remember to check and update your variable names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants