Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JThh] ip #364

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
556af3f
Add Gradle support
May 24, 2020
41d3174
Init Level 1. Greet, Echo, Exit
Jan 17, 2023
b74f259
Init Level 2. Add, List
Jan 17, 2023
9926150
Finish Level 3. Mark as Done
Jan 17, 2023
f1781e5
Finish Level 3. Mark as Done
Jan 17, 2023
3272357
Finish Level 4. ToDos, Events, Deadlines
Jan 18, 2023
f35eeda
Finish Level 6. Delete
Jan 18, 2023
cef55ac
Finish Level 6. Delete
Jan 18, 2023
89b047b
Finish Level 6. Delete
Jan 18, 2023
8637026
Finish Level 6. Delete
Jan 18, 2023
a01b890
Finish Level 5. Exception
Jan 18, 2023
eb0d5db
Finish Level 5. Exception
Jan 18, 2023
e1aa1ec
Merge remote-tracking branch 'origin/master'
Jan 18, 2023
f1c11d3
Level-7 Finish
Jan 31, 2023
a353a03
Level-8 Finish
Jan 31, 2023
6300a04
Merge branch 'branch-Level-7'
Jan 31, 2023
0792b27
Level-8 Finish
Jan 31, 2023
7105732
Merge branch 'branch-Level-7'
Jan 31, 2023
717395e
Update Duke.java
JThh Jan 31, 2023
dd2153c
Merge branch 'master' into Level-8
JThh Jan 31, 2023
2cc5e4a
Merge pull request #1 from JThh/Level-8
JThh Jan 31, 2023
6de7960
More OOP in-progress
Feb 3, 2023
e6212c5
More OOP
Feb 17, 2023
c221412
resolved conflicts
Feb 17, 2023
28ed102
Merge pull request #3 from JThh/branch-Level-7
JThh Feb 17, 2023
b3a0071
removed unused files
Feb 17, 2023
7a694e6
added gradle support
Feb 17, 2023
b966dc8
Merge branch 'master' into add-gradle-support
Feb 17, 2023
2d9ca5e
Modified tests
Feb 18, 2023
2fe004b
add workflow script and modify test files
Feb 18, 2023
c99555e
add date parsing function and fix unit tests
Feb 19, 2023
a605b0d
finish jar file creation
Feb 19, 2023
88a162a
omit data
Feb 19, 2023
b7554d5
Create gradle.yml
JThh Feb 19, 2023
6d29b0c
add gui init
Feb 19, 2023
b20bdf1
fixed ci tests
Feb 19, 2023
0e2d481
fix gradle
Feb 19, 2023
8c7b0c8
add java doc
Feb 19, 2023
b36e5a0
refactor codes and add command class
Feb 19, 2023
26d5c27
fixes merging conflicts
Feb 19, 2023
0bc35eb
finishes adding find function
Feb 19, 2023
3dc32ba
Merge branch 'master' into branch-A-JavaDoc
Feb 19, 2023
8baab87
Add gui
Feb 19, 2023
1261027
Merge branch 'master' into branch-A-JavaDoc
Feb 19, 2023
b9be6ca
Fix GUI
Feb 19, 2023
962a618
Add Ui png
Feb 19, 2023
f58e500
Fix gui
Feb 20, 2023
8ab92df
Merge branch 'master' into branch-A-JavaDoc
Feb 20, 2023
d36f2ce
Make command class attributes private and methods non-static
Feb 20, 2023
ee750ad
Finish comments
Feb 20, 2023
a3f3019
Add assertions for input sanity check
Feb 20, 2023
51ad510
Refactor codes
Feb 20, 2023
5533235
Refactor codes
Feb 20, 2023
9497575
Fix CI
Feb 20, 2023
aa88a18
Fix CI
Feb 20, 2023
d7ecdad
Add check duplicate functionality
Feb 20, 2023
033f3ee
Fix CI
Feb 20, 2023
503fbb9
Fix CI
Feb 20, 2023
083b67d
Fix CI: another trial
Feb 20, 2023
46b8178
Replace ui png
Feb 20, 2023
9749f0a
Fix CI
Feb 20, 2023
3df55f8
Add streaming behaviors
Feb 20, 2023
4899d04
Add streaming behaviors
Feb 20, 2023
5a6e8fe
Add README.md
Feb 20, 2023
fb6b17f
Merge pull request #4 from JThh/branch-A-CodeQuality
JThh Feb 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/Duke.java
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ public DukeEmptyTaskException (String msg) {
public static String parse_date(String s) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "parse_date", perhaps you could rename it to "parseDate", which conforms to the coding standard?

DateTimeFormatter read_fmt = DateTimeFormatter.ofPattern("yyyy-MM-dd HHmm");
DateTimeFormatter print_fmt = DateTimeFormatter.ofPattern("MMM dd yyyy");

try {
LocalDate lt = LocalDate.parse(s, read_fmt);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make the argument more expressive?

return lt.format(print_fmt);
Expand Down Expand Up @@ -234,4 +235,4 @@ public static void main(String[] args) {
}
}
}
}
}