-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jason] Duke Increments #368
base: master
Are you sure you want to change the base?
[Jason] Duke Increments #368
Conversation
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (#9)
Greet, Echo, Exit
Add, List
Mark as Done Use a class to represent tasks
ToDos, Events, Deadlines Use Inheritance to support multiple task types
Test using the I/O redirection technique
Handle Errors Use Exceptions to handle errors
Delete Use Java Collections classes
Save
Dates and Times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on implementing the features. But I think it would be better if the project can be more OOP. I am not really sure about certain classes implemented as some do not have a lot of content inside. Maybe there can be more classes to represent different commands for example.
src/main/java/Duke.java
Outdated
public static void main(String[] args) throws DukeException, IOException { | ||
new Duke("list.txt").run(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is advisable to remove the commented code if it is not used to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You caught me mid-refactor, laptop ran out of battery so I had to make a Checkpoint commit.
src/main/java/Ui.java
Outdated
@@ -0,0 +1,9 @@ | |||
public class Ui { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if there can be more functionality to represent interaction with users, including the different response messages.
Make the code more OOP
Divide classes into packages
Add JUnit tests
Package the App as a JAR file
Automate project builds using Gradle
Add JavaDoc comments
Tweak the code to comply with a coding standard
Improve code quality
W5 - A-CodeQuality
Use Lambdas
W5 - A-Lambdas
Use Assertions
Use Travis for CI
W5 - A-Assertations
Use Streams
W5 - A-Streams
Give help to users
More flexibility in searching for items
Statistics and insights
No description provided.