-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.5][T11-B2] PrisonBook #78
base: master
Are you sure you want to change the base?
Conversation
Update DeveloperGuide: user stories, use cases, non-functional requirements and glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per discussion in the tutorial, user stories, use cases and NFRs have been updated. Overall a good PR.
Issue tracker hasn't been setup yet, and are advised to do so.
Its also nice to see that Travis builds are taken into account.
Please read the minor comments made. Please DO NOT close this PR as we will use it for tracking your milestones!
docs/DeveloperGuide.adoc
Outdated
+ | ||
Use case resumes at step 2. | ||
[discrete] | ||
=== Use case: Get the list of prisoners in a certain cell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rendering of this guide shows an indentation error at this point. Please try to fix that.
docs/DeveloperGuide.adoc
Outdated
. Should work for 32-bit and 64-bit environments | ||
. System should respond within 2 seconds | ||
. Should have different levels of access for users of different ranks. | ||
. Should have a backup copy at all times in case a user accidentally deletes any information. | ||
|
||
_{More to be added}_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This phrase should be removed is the list is exhaustively filled.
|
||
By: `Team SE-EDU` Since: `Jun 2016` Licence: `MIT` | ||
By: `CS2103-T11-B2` Since: `Jan 2018` Licence: `MIT` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on correcting this as most of the teams missed it.
Some comments. Please review and work on them
|
* fix merge errors * Add dummy classes to support import feature * Add details in JobEntry and SessionData * more edits * Add classes to support ImportSession * Apply SLAP to make methods smaller * Add ImportSession method to read excel file. * Add SheetHeaderFields class * Add SheetWithHeaderFields to extract row and column operations * Finish ImportSession feature to write to file * trailing whitespace * Extract messages in ImportSession as constants. Write dummy ImportAllCommand, with functional support classes. * Use unmodifiableList for getting lists in sessionData and jobEntry. * Implement importAll command * fix modelStub * fix checkstyle error * fix checkstyle error * Rename method addUnreviewedJobEntries to addSheet
Merge pull request #39 from philos22/master
AddCellCommand with exceptions and tests
Merge main branch into remote repo
Calendar Command Functionality
v1.3 for release
Update status bar and UserGuide
Updated Zacci Portfolio
Updated zacci portfolio
[v1.5] Documentation
[v1.5] Style
[v1.5]portfolio minimize
[v1.5] make class diagram smaller
No description provided.