[v1.0][W15-B1] E.T. (Employees Tracker) #43

IzHoBX · 2018-03-07T16:30:09Z

Add user stories
Add use cases
Add NFRs
Add lock and unlock command
Add rate command
Add sort command
Add find by any field

nus-se-pr-bot · 2018-03-08T02:37:13Z

Hi @IzHoBX, your pull request title is invalid.

For phase A, it should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2).

For phase B, it should be in the format of [v1.x][Team ID] Product Name.

Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

devamanyu

Good coverage of user-stories, use cases, and NFRs. Please address some minor comments mentioned in this review.

A glance at your organization repo showed that some individual PRs were merged despite Travis build failure (e.g., Sort command, Rate command, etc.). Normally it is a good idea to merge only passed builds into the master branch. This will help you in isolating broken commits. Coding standard violation is one of the main issues of Travis build failure and thus sticking to the standards provided is of utmost importance.

Also, it is nice to see that issue-tracker has been set up.

Do not close this PR, as we'll be using this PR for your subsequent milestones!

devamanyu · 2018-03-10T03:04:58Z

README.adoc

@@ -1,7 +1,7 @@
 = Address Book (Level 4)


I guess your project is not Address Book anymore :p, please update the Address Book mentions from all instances. You might also need to update or remove stuff that relates only to address-book and not to your project.

devamanyu · 2018-03-10T03:05:34Z

docs/DeveloperGuide.adoc

@@ -10,7 +10,8 @@ ifdef::env-github[]
 :tip-caption: :bulb:
 :note-caption: :information_source:
 endif::[]
-:repoURL: https://github.com/se-edu/addressbook-level4/tree/master
+:repoURL: https://github.com/CS2103JAN2018-W15-B1/main/tree/master
+

 By: `Team SE-EDU`      Since: `Jun 2016`      Licence: `MIT`


Team name should be different.

devamanyu · 2018-03-10T03:11:01Z

docs/DeveloperGuide.adoc

+
+|`* * *`|user |add a new person | include employees that have just entered the company
+
+|`* * *`|user |each employee has his/her dedicated timetable | trace progress of that person


This particular user story doesn't adhere to the "I want to..." prefix. When read together, the whole story should be grammatically coherent.

devamanyu · 2018-03-10T03:12:45Z

docs/DeveloperGuide.adoc

+
+|`* * *`|user |add notes on a timetable entry or on a person | include more details about the entry
+
+|`* * *`|user |search employees by specific criteria | search employees more easily


Might be a good idea to enlist a couple of criteria's possible. That way reader can understand which criteria you are planning to consider.

devamanyu · 2018-03-10T03:15:15Z

docs/DeveloperGuide.adoc

+
+|`*`|user |unlock the addressbook |continue to use the app after leaving it locked
+
+|`*`|user |write a review to an employee that has ever worked below me| information his/her current manager of his/her performance
 |=======================================================================

 _{More to be added}_


This comment can be removed if no more stories are planned to be added.

devamanyu · 2018-03-10T03:23:06Z

docs/DeveloperGuide.adoc

-3.  User requests to delete a specific person in the list
-4.  AddressBook deletes the person
+1. User requests to list employees
+2. AddressBook shows a list of employees


Its probably best to rename "AddressBook" as this new app is not exactly an "Address Book".

devamanyu · 2018-03-10T03:42:08Z

docs/DeveloperGuide.adoc

-.  Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
-.  A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.
+.  Should be able to hold up to 1000 persons without a noticeable sluggishness (i.e. response time >500ms) in performance for typical usage.
+.  A user with above average typing speed (i.e. >=45 words per minute) for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.


Nice to see changes made as per discussion in the tutorial.

Enhance help/man command

Use CalendarFX to display Calendar View

devamanyu · 2018-03-27T07:43:36Z

Overall User Guide has been updated and reflects the plan. In Developer Guide, I could not find sequence diagrams in the implementations. Generally, its good to add visual cues to aid the reader.
This is particularly important when explaining how to perform features such as adding events on timetables, locking and unlocking of the app, etc.

In the User Guide its good to see the plan for different features correlating to different version releases.

Make undo

Update collate

Incremental Update before v1.5rc

Documentation and Collate

Update AbooutUs

UserGuide: Update image

Re-collate

AboutUs.adoc and PPP

Fix capitalization

Update Class Diagram

Final documentation update

update ppp html version

nus-se-pr-bot added the FormatCheckRequested label Mar 8, 2018

IzHoBX changed the title ~~[v1.x][W15-B1] E.T. (Employees Tracker)~~ [v1.0][W15-B1] E.T. (Employees Tracker) Mar 8, 2018

nus-se-pr-bot added team.B1 tutorial.W15 and removed FormatCheckRequested labels Mar 8, 2018

nus-se-pr-bot assigned devamanyu and hwkchia Mar 8, 2018

devamanyu reviewed Mar 10, 2018

View reviewed changes

devamanyu added the reviewed-v1_0 label Mar 10, 2018

YuanQLLer pushed a commit to YuanQLLer/addressbook-level4 that referenced this pull request Mar 18, 2018

Merge pull request nus-cs2103-AY1718S2#43 from jasmoon/master

b2dcdeb

Enhance help/man command

wynonaK added a commit to wynonaK/addressbook-level4 that referenced this pull request Mar 23, 2018

Merge pull request nus-cs2103-AY1718S2#43 from Robert-Peng/Major1.1

c6b29cd

Use CalendarFX to display Calendar View

devamanyu added reviewed-v1_2 reviewed-v1_1 labels Mar 27, 2018

Yoochard and others added 15 commits April 9, 2018 20:02

update background colour of list-view and status-bar

60104a5

Merge branch 'master' of https://github.com/CS2103JAN2018-W15-B1/main

c93367e

change filled text to reduce warning when ui starts

8594271

make add photo commmand undoable

0ee7969

junit tests

8afdb30

junit tests

9de2037

fix style error

ca23c65

fix test error

abf8fc0

Merge pull request #201 from crizyli/make_undo

432ab26

Make undo

update collate

d1cbda9

update collate file

369d300

Merge pull request #202 from crizyli/update_collate

090ae85

Update collate

Merge branch 'master' of https://github.com/CS2103JAN2018-W15-B1/main

797cd92

Merge pull request #13 from CS2103JAN2018-W15-B1/master

5b57aac

Incremental Update before v1.5rc

update suggested commands usage

3deb85b

emer7 and others added 30 commits April 15, 2018 21:54

Documentation

23cfd6e

Collate

c097ff3

Merge pull request #243 from emer7/master

3becf49

Documentation and Collate

Merge pull request #242 from IzHoBX/master

7396244

Update AbooutUs

UserGuide: Update image

2ff0d51

Merge pull request #244 from emer7/master

9b8ef89

UserGuide: Update image

Re-collate

f158222

Merge pull request #245 from emer7/master

356413a

Re-collate

AboutUs.adoc and PPP

8a5e12d

Merge pull request #246 from emer7/master

ab00fe4

AboutUs.adoc and PPP

Fix capitalization

38dc3fb

Merge pull request #247 from emer7/master

f059d8b

Fix capitalization

Update README.adoc

11e1c6a

Update Class Diagram

cde4eb3

Merge pull request #248 from emer7/master

c278c4f

Update Class Diagram

Final documentation update

a3145a5

Merge branch 'master' into master

fb13267

Merge pull request #249 from IzHoBX/master

d7e349f

Final documentation update

Adds IzHoBX.html

b2c3cd9

Deletes IzHoBX.html

2551f98

Update Yoochard.adoc

f5761ad

Update Yoochard.adoc

2dc1ff5

Update Yoochard.adoc

75c647b

update ppp html version

d155964

new line added at EOF

80e5895

Merge pull request #250 from Yoochard/master

5dd1896

update ppp html version

Add files via upload

3888d7c

Delete crizyli.html

b361fdd

Add files via upload

d5db7a7

Update crizyli.html

365a981

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v1.0][W15-B1] E.T. (Employees Tracker) #43

[v1.0][W15-B1] E.T. (Employees Tracker) #43

IzHoBX commented Mar 7, 2018

nus-se-pr-bot commented Mar 8, 2018

devamanyu left a comment

devamanyu Mar 10, 2018

devamanyu Mar 10, 2018

devamanyu Mar 10, 2018

devamanyu Mar 10, 2018

devamanyu Mar 10, 2018

devamanyu Mar 10, 2018

devamanyu Mar 10, 2018

devamanyu commented Mar 27, 2018


		\|`* * *`\|user \|add a new person \| include employees that have just entered the company

		\|`* * *`\|user \|each employee has his/her dedicated timetable \| trace progress of that person


		\|`* * *`\|user \|add notes on a timetable entry or on a person \| include more details about the entry

		\|`* * *`\|user \|search employees by specific criteria \| search employees more easily

[v1.0][W15-B1] E.T. (Employees Tracker) #43

Are you sure you want to change the base?

[v1.0][W15-B1] E.T. (Employees Tracker) #43

Conversation

IzHoBX commented Mar 7, 2018

nus-se-pr-bot commented Mar 8, 2018

devamanyu left a comment

Choose a reason for hiding this comment

devamanyu Mar 10, 2018

Choose a reason for hiding this comment

devamanyu Mar 10, 2018

Choose a reason for hiding this comment

devamanyu Mar 10, 2018

Choose a reason for hiding this comment

devamanyu Mar 10, 2018

Choose a reason for hiding this comment

devamanyu Mar 10, 2018

Choose a reason for hiding this comment

devamanyu Mar 10, 2018

Choose a reason for hiding this comment

devamanyu Mar 10, 2018

Choose a reason for hiding this comment

devamanyu commented Mar 27, 2018