[W8.6b][T09-B3] Kang Anmin #966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edit a read-only file" This reverts commit d34e230.
All changes are based on an assumption that the add/delete tag command already exists. Tests and docs are not updated.
|
|
||
| StringBuffer tagLog = new StringBuffer(); | ||
|
|
||
| for(Tagging tagging: addressBook.tagLog) { |
There was a problem hiding this comment.
Coding standard violation. Missing an empty space.
| @@ -24,13 +26,15 @@ | |||
|
|
|||
| private final UniquePersonList allPersons; | |||
| private final UniqueTagList allTags; // can contain tags not attached to any person | |||
| public ArrayList<Tagging> tagLog; | |||
There was a problem hiding this comment.
Good, this is a correct place to put the list based on the UML.. May be tagList is a better name.
| import seedu.addressbook.data.person.Person; | ||
|
|
||
| /** | ||
| * It records a transaction of a tag addition/deletion |
| public class Tagging { | ||
| private Person person; | ||
| private Tag tag; | ||
| private boolean addition; // true means it is an addition, false means deletion |
There was a problem hiding this comment.
Coding standard violation for boolean.
Using boolean is fine now since this LO requires only two states. What if later you need to capture more than two states?
| } | ||
|
|
||
| public String toString() { | ||
| return (addition?"+ ":"- ") + person.getName() + " " + tag.toString(); |
There was a problem hiding this comment.
I think this ternary operator violates our coding standard. Missing empty spaces?
|
@EdwardKSG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add/delete tag command is not implemented.
All changes are based on an assumption that the add/delete tag command already exists.
Tests and docs are not updated.