Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W6.1h][W13-B1] Li PengCheng #889

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jacoblipech
Copy link

No description provided.

Copy link

@hovinh hovinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, you met the requirement to implement the new interface. 👍
By the way, I haven't seen you updated the NFR.

@@ -0,0 +1,6 @@
package seedu.addressbook.data.person;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a header comment here.

* Returns a concatenated version of the printable strings of each object.
*/
public String getPrintableString(Printable... printables){
final StringJoiner appendData = new StringJoiner(",");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job using a StringJoiner here 👍

@hovinh hovinh added the Reviewed label Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants