-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W6.1h][W13-B1] Li PengCheng #889
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, you met the requirement to implement the new interface. 👍
By the way, I haven't seen you updated the NFR.
@@ -0,0 +1,6 @@ | |||
package seedu.addressbook.data.person; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a header comment here.
* Returns a concatenated version of the printable strings of each object. | ||
*/ | ||
public String getPrintableString(Printable... printables){ | ||
final StringJoiner appendData = new StringJoiner(","); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job using a StringJoiner here 👍
No description provided.