-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change title to fix folder name for Windows user #1839
base: main
Are you sure you want to change the base?
Conversation
Fix name (in particular for Windows users)
😊 |
And it's the right way for fix #1835. Good job. Hope to merge it ASAP. |
I agree. However, this PR does not fully resolve #1835. Even with this PR in place, you get an error when using this theme as go/hugo module:
This is due to the use of |
Darn, sorry for the sloppy work. I fixed it. Since we partially use already domains as folder names, may I suggest to consistently roll out this naming convention to avoid this problem in the future? |
Can't agree more. Similar situations is as hell |
This PR fixes the issue for Windows users introduced in #1780 by a title that contains
:
(thanks @eallion for the hint!)