-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jupytext requirement for binder. #217
Conversation
I think binder looks at env.yaml not at requirements.txt maybe that's the reason that binder don't have jupytext installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try - I think it makes sense. Thanks @Carreau !
what about |
You will still need |
you mean an ipynb notebook? (That is what I do with astroML and really don't like the process/setup to have both mb and ipynb (but also, I need the outputs at least for a couple of notebooks as some are too expensive to execute each time in CI) |
Yes, that is what I meant is automatically creating those for when people are interacting with the binder instance. I am not suggesting keeping those in git though! That would require some improvements/modifications to CI to enable that though. |
We are doing something similar here: https://github.com/scipy/scipy/blob/d304e95751d52dd327e10634b06c17f0440ba5bc/doc/Makefile#L116 |
We do that here, too, they are then pushed to the https://github.com/numpy/numpy-tutorials/tree/gh-pages/_sources/content |
I'd rather pursue client-side interactivity (ideally on the page itself) than put effort into adding |
I agree, I think that would be ideal. But as a compromise while that doesn't happen we can have binder point to the ipynb files. I'll try to poke around. |
In the new https://mystmd.org/guide/integrating-jupyter Because the numpy tutorials are using well-supported packages, I think that adding We currently haven't enabled editing directly on the page yet, but it is on our roadmap. Curious if @rossbar and @melissawm this is getting close to the direction you imagine? |
Indeed - this was one of the features from that was most compelling from my perspective! It's great to see that on-page interactivity is on the roadmap! |
Yes, 100%! Should we follow that issue for updates? |
I am tracking the request from MyST's side here: |
I think binder looks at env.yaml not at requirements.txt maybe that's the reason that binder don't have jupytext installed