Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt doc preview with mystjs. #212

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

rossbar
Copy link
Collaborator

@rossbar rossbar commented Jun 4, 2024

No description provided.

.circleci/config.yml Outdated Show resolved Hide resolved
Co-authored-by: Rowan Cockett <[email protected]>
@rowanc1
Copy link
Contributor

rowanc1 commented Jun 5, 2024

Looks like the site is ~working, however, internal links don't point to the .html and there is no auto redirect for these on the service as is common on most static site generators (including github pages).

Preview:
https://output.circle-artifacts.com/output/job/2f17c17e-a680-4e5c-a008-5460b25130ac/artifacts/0/_build/html/index.html

Bug/feature request on CircleCI:
https://discuss.circleci.com/t/circle-artifacts-com-not-using-index-html/320

We can also potentially address this in MyST, but the fix is going to be cumbersome.

@rossbar
Copy link
Collaborator Author

rossbar commented Jun 5, 2024

Thanks for diving into this @rowanc1 , this is very helpful!

@rossbar rossbar merged commit 7b75b2c into numpy:mystjs Jun 5, 2024
2 checks passed
@rossbar rossbar deleted the mystjs-ci-preview branch June 5, 2024 17:07
@rossbar
Copy link
Collaborator Author

rossbar commented Jun 5, 2024

FWIW I left the main components of the deployment workflow commented out - to be addressed separately!

@InessaPawson
Copy link
Member

The docs in preview look stunning!

@bsipocz
Copy link
Member

bsipocz commented Jul 15, 2024

We should probably write up a tracking issue to see a list of TODO items about the missing tasks that are required to be done before we can switch over to this in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants