Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cisco-anyconnect.svg #2854

Closed
wants to merge 2 commits into from
Closed

Create cisco-anyconnect.svg #2854

wants to merge 2 commits into from

Conversation

r0ckarong
Copy link

Created icon from scratch with some inspiration.

cisco-anyconnect

This would fix https://github.com/numixproject/numix-icon-theme-circle/issues/2820

Created icon from scratch with some inspiration
@r0ckarong
Copy link
Author

How does the actual integration work? The svg is not named like the original icon and it's obviously not a png icon file. Do you guys render this out with the correct name according to the icon request? If i can help with this at all let me know.

@palob
Copy link
Member

palob commented Feb 14, 2016

You can copy the .desktop file to ~/.local/share/applications and edit the icon line to simply Icon=cisco-annyconnect.

Alternatively, you can use the hardcode-fixer script. Please report the hardcoded icon path against this repo or open a PR fixing it.

@palob
Copy link
Member

palob commented Feb 14, 2016

@mnapp For some reason you question seems to have vanished, new contributors are always welcome.

It looks like you have done the baseplate from scratch. Just start from an existing icon, delete the symbol and recolour the baseplate.

The reason for your impression of wrong size/misalignment arises from your symbol not being aligned to the pixel grid (toggled with the # key in Inkscape).
pixelgrid
If a vertical/lateral border of two differently coloured regions isn't in line with the pixel grid a line with interpolated colouring will be rendered in between. The result is a blurry shape.

Recreated from existing backplate, aligned with grid, resized icon core, ran svgcleaner
@r0ckarong
Copy link
Author

Sorry yeah, I removed that comment because I figure out how to set the SVG scalable in the .desktop file and then it looked right. I've now taken your advice and recreated the icon from an existing backplate and properly aligned it with the grid. I also ran svgcleaner to make it more compact. Thanks for the help.

*Edit: *
Another question: How do I properly export a 48x48 png version of this to use on my system? Since I use the svg it looks way bigger in the Unity apps tray (not the launcher) than all the other Numix icons. When I try to export from inkscape using "Drawing" as the base I always get weird aspect ratio like 48x46 or something. I don't get this at all.

@palob
Copy link
Member

palob commented Feb 15, 2016

Probably due to svgcleaner arguments you ran there's strange stuff in your SVG's source code and the symbol object exceeds the baseplate. It looks like you've done the shadow using a filter. Just duplicate the symbol shape and make it black with 10% opacity.

That's the only reasons I can think of why it would appear bigger.

When you export from Inkscape use "page". Anyway, the Inkscape raster export is a PITA imo.
Alternatively you can for instance open the SVG in GIMP, render at 48x48 and export to PNG.
Then again you shouldn't need to go the PNG way at all.

@palob
Copy link
Member

palob commented Feb 15, 2016

I've had another look at the icon.

We've got those design guidelines. Yes, absolutely hidden and not thorough.

According to those right now your symbol is a bit too wide. Furthermore it isn't exactly symmetrical and some lines are still misaligned. Can you recreate the symbol using a combination basic shapes like (rounded) rectangles and circles? You'll need to use path operations like Union, Difference, Intersection.....

@r0ckarong
Copy link
Author

I ran svgcleaner-gui with default settings so no idea how to correct this. As I mentioned before I have no real experience with vector graphics before this. I know how to use paths somewhat in GIMP and others but I need to spend more time to actually work with it in Inkscape.

I will give remaking the symbol a shot in the next couple of days.

@palob
Copy link
Member

palob commented Feb 16, 2016

For cleaning up SVG icons you can use this script. It runs svgcleaner-cli without the harmful options.

@r0ckarong r0ckarong closed this Apr 24, 2016
@r0ckarong r0ckarong deleted the anyconnect-icon branch April 24, 2016 18:50
@kmyi kmyi mentioned this pull request Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants