-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cisco-anyconnect.svg #2854
Conversation
Created icon from scratch with some inspiration
How does the actual integration work? The svg is not named like the original icon and it's obviously not a png icon file. Do you guys render this out with the correct name according to the icon request? If i can help with this at all let me know. |
You can copy the Alternatively, you can use the hardcode-fixer script. Please report the hardcoded icon path against this repo or open a PR fixing it. |
@mnapp For some reason you question seems to have vanished, new contributors are always welcome. It looks like you have done the baseplate from scratch. Just start from an existing icon, delete the symbol and recolour the baseplate. The reason for your impression of wrong size/misalignment arises from your symbol not being aligned to the pixel grid (toggled with the |
Recreated from existing backplate, aligned with grid, resized icon core, ran svgcleaner
Sorry yeah, I removed that comment because I figure out how to set the SVG scalable in the .desktop file and then it looked right. I've now taken your advice and recreated the icon from an existing backplate and properly aligned it with the grid. I also ran svgcleaner to make it more compact. Thanks for the help. *Edit: * |
Probably due to svgcleaner arguments you ran there's strange stuff in your SVG's source code and the symbol object exceeds the baseplate. It looks like you've done the shadow using a filter. Just duplicate the symbol shape and make it black with 10% opacity. That's the only reasons I can think of why it would appear bigger. When you export from Inkscape use "page". Anyway, the Inkscape raster export is a PITA imo. |
I've had another look at the icon. We've got those design guidelines. Yes, absolutely hidden and not thorough. According to those right now your symbol is a bit too wide. Furthermore it isn't exactly symmetrical and some lines are still misaligned. Can you recreate the symbol using a combination basic shapes like (rounded) rectangles and circles? You'll need to use path operations like |
I ran svgcleaner-gui with default settings so no idea how to correct this. As I mentioned before I have no real experience with vector graphics before this. I know how to use paths somewhat in GIMP and others but I need to spend more time to actually work with it in Inkscape. I will give remaking the symbol a shot in the next couple of days. |
For cleaning up SVG icons you can use this script. It runs |
Created icon from scratch with some inspiration.
This would fix https://github.com/numixproject/numix-icon-theme-circle/issues/2820