Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add fixtures, parsing unit tests, e2e tests #11

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Conversation

Lowaiz
Copy link
Member

@Lowaiz Lowaiz commented Jul 23, 2024

Add tests

All fixtures are from a test instance and do not contain any sensitive information, only string like "test-account", "test-cipher", ...

@Lujeni
Copy link
Member

Lujeni commented Sep 17, 2024

@Lowaiz, thanks for the merge request! It's quite large, so it's been a bit challenging to thoroughly review all the code.

  • I made some improvements to the README, building on your great work (mostly on contributing/testing part)
  • I've moved all the TODO items to separate issues for better tracking.
  • I also "resolved" the mypy warnings. :)

pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@gaby
Copy link

gaby commented Sep 20, 2024

Unrelated to this PR, but the hkdf dependency used here has been updated in 9 years. https://pypi.org/project/hkdf/

@Lowaiz Lowaiz merged commit 77f94e6 into main Sep 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants