Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store to opaque ptr #1098

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexander-shaposhnikov
Copy link

If ptr.type.is_opaque is True it doesn't need to have ptr.type.pointee attribute.
Add a unit test.

@sklam
Copy link
Member

sklam commented Nov 12, 2024

@rj-jesus can you review this?

@rj-jesus
Copy link
Contributor

@sklam Yep, sure.
Thanks for the patch, @alexander-shaposhnikov.
In general it LGTM, my only comment would be that the new test test_store could maybe be part of test_mem_ops, but I don't think this is critical.

@alexander-shaposhnikov
Copy link
Author

Many thanks, I've updated the PR.

Copy link
Contributor

@rj-jesus rj-jesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, LGTM!
(@sklam I can't approve it myself.)

@alexander-shaposhnikov
Copy link
Author

@sklam (would be amazing if you could merge this in, many thanks in advance)

@gmarkall gmarkall added this to the v0.44.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants