SD channel indexing improvements #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe there were some issues with the digitizer instrument and/or interface regarding one-based indexing that I fixed in Venus (PR #36 and perhaps local changes on Venus). We should add those changes into this PR. |
… into hotfix/keysight_sd_indexing
|
I pushed all the changes in Venus to this branch. One remaining issue is that PR #36 seems very similar, so we should probably absorb that PR into this one. |
|
Ah didn't realize this PR includes all changes from #36. I'll do a review soon |
Fixes from Queenie PC
RostyslavSavytskyy
previously requested changes
Feb 17, 2021
|
@Ifefu Do you have any further changes for the M3202A? If not, then it would be good to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds channel indexing option to digitizer
__init__.Also adds a distinct set of default indices for legacy instruments c.f. modern instruments.
Incorporates the changes from this PR and thus supercedes.