Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps Neosync to v0.5 #3084

Merged
merged 13 commits into from
Jan 3, 2025
Merged

Bumps Neosync to v0.5 #3084

merged 13 commits into from
Jan 3, 2025

Conversation

nickzelei
Copy link
Member

This is a larger release that does a number of things:

  1. Removes all @deprecated fields in the API. These have all been marked as deprecated for some time and are not used by any of the official clients or the App.
  2. Removes unused or deprecated methods. The connection data service had a few erroneous methods that have been replaced for some time by better methods.
  3. Moves Object Storage connections to be behind an Enterprise license.
  4. Fixes many Postgres data types during syncs
  5. Introduces the Neosync data type structure that is used for piping data through the system
  6. Fixes (and breaks the old way) of syncing S3 data types to allow for better retention of data types during CLI syncs
  7. Logs and Metrics are now behind an Enterprise License. This is only for surfacing them, not for exposing them to be read by external systems
  8. Updates TypeScript SDK to use the new Connection v2 API. Anyone that is using the TS sdk will have to update their scripts to support the newer method which lacks classes. The docs have been updated appropriately
  9. Adds RBAC - API Keys are now admin only (until we add fine grained control)
  10. Other minor bug fixes and updates to tests

@nickzelei nickzelei added the enhancement New feature or request label Jan 3, 2025
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 7:04pm

Copy link

github-actions bot commented Jan 3, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (36)Jan 3, 2025, 7:05 PM

@nickzelei nickzelei marked this pull request as ready for review January 3, 2025 19:06
Copy link
Contributor

@alishakawaguchi alishakawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 54.79705% with 245 lines in your changes missing coverage. Please review.

Project coverage is 31.75%. Comparing base (d5843a9) to head (1530eba).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...kend/pkg/integration-test/integration-test-util.go 0.00% 56 Missing ⚠️
...1alpha1/connection-data-service/connection-data.go 4.16% 46 Missing ⚠️
cli/internal/cmds/neosync/sync/sync.go 0.00% 27 Missing ⚠️
backend/pkg/integration-test/mux.go 90.86% 12 Missing and 6 partials ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 15 Missing ⚠️
cli/internal/cmds/neosync/sync/job.go 0.00% 15 Missing ⚠️
backend/pkg/sqlmanager/mssql/mssql-manager.go 0.00% 14 Missing ⚠️
backend/pkg/integration-test/integration-test.go 57.14% 9 Missing and 3 partials ⚠️
cli/internal/cmds/neosync/sync/config.go 0.00% 12 Missing ⚠️
backend/internal/userdata/user.go 50.00% 8 Missing and 3 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   34.79%   31.75%   -3.04%     
==========================================
  Files         350      357       +7     
  Lines       40761    41570     +809     
==========================================
- Hits        14181    13202     -979     
- Misses      24888    26822    +1934     
+ Partials     1692     1546     -146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit f0f4e54 into main Jan 3, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants