Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1690: Exposes FE to license checks, puts object storage behind license #3072

Merged

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Dec 19, 2024

image

Copy link

linear bot commented Dec 19, 2024

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 6:08pm

@nickzelei nickzelei changed the base branch from main to develop/v0.5 December 19, 2024 22:16
Copy link

github-actions bot commented Dec 19, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 23, 2024, 6:08 PM

@nickzelei nickzelei changed the title Nick/neos 1690 expose license information via rpc NEOS-1690: fj Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 79.44444% with 74 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop/v0.5@f117a25). Learn more about missing BASE report.

Files with missing lines Patch % Lines
backend/pkg/integration-test/mux.go 90.86% 12 Missing and 6 partials ⚠️
backend/pkg/integration-test/integration-test.go 57.14% 9 Missing and 3 partials ⚠️
backend/internal/userdata/user.go 50.00% 8 Missing and 3 partials ⚠️
internal/ee/cloud-license/license.go 0.00% 5 Missing ⚠️
internal/ee/license/cascade.go 0.00% 5 Missing ⚠️
internal/ee/license/license.go 0.00% 5 Missing ⚠️
worker/pkg/integration-test/datasync_workflow.go 0.00% 4 Missing ⚠️
backend/internal/ee/rbac/policy.go 0.00% 3 Missing ⚠️
backend/pkg/integration-test/clients.go 91.89% 3 Missing ⚠️
...rvices/mgmt/v1alpha1/user-account-service/users.go 75.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@               Coverage Diff               @@
##             develop/v0.5    #3072   +/-   ##
===============================================
  Coverage                ?   34.37%           
===============================================
  Files                   ?      356           
  Lines                   ?    41303           
  Branches                ?        0           
===============================================
  Hits                    ?    14196           
  Misses                  ?    25392           
  Partials                ?     1715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei changed the title NEOS-1690: fj NEOS-1690: Exposes FE to license checks, puts object storage behind license Dec 20, 2024
@nickzelei nickzelei marked this pull request as ready for review December 20, 2024 18:08
@nickzelei nickzelei merged commit 7698311 into develop/v0.5 Dec 23, 2024
18 checks passed
@nickzelei nickzelei deleted the nick/neos-1690-expose-license-information-via-rpc branch December 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants