Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1672: Fixes worker error shutdown, k8s helm secret revisions #3044

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Dec 12, 2024

  • Fixes the worker not properly shutting down on error. This was being caused by not properly calling shutdown on the mongo connection manager
  • Adds more logging to the worker startup
  • Updates helm secrets to be revisioned based on their shasum. This fixes the issue of secrets not properly being removed from the secret (due to how k8s manages secret merges) which was causing presence issues during startup.
  • Removes the rollMe from the helm annotations. Now that secrets are re-generated on change, if there are no changes the deployment will not roll for no reason

Copy link

linear bot commented Dec 12, 2024

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Dec 12, 2024 9:37pm

@nickzelei nickzelei added the bug Something isn't working label Dec 12, 2024
@@ -281,14 +282,14 @@ func serve(ctx context.Context) error {

mongoconnmanager := connectionmanager.NewConnectionManager(mongoprovider.NewProvider())
go mongoconnmanager.Reaper(logger)
defer sqlconnmanager.Shutdown(logger)
defer mongoconnmanager.Shutdown(logger)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 35.17%. Comparing base (7461f83) to head (bfd1624).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/connection-manager/manager.go 0.00% 10 Missing ⚠️
backend/internal/cmds/mgmt/mgmt.go 0.00% 8 Missing ⚠️
worker/internal/cmds/worker/worker.go 0.00% 8 Missing ⚠️
worker/internal/cmds/worker/serve/serve.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
- Coverage   35.18%   35.17%   -0.02%     
==========================================
  Files         346      346              
  Lines       39995    40016      +21     
==========================================
  Hits        14074    14074              
- Misses      24262    24283      +21     
  Partials     1659     1659              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review December 13, 2024 17:06
@nickzelei nickzelei merged commit 606354f into main Dec 13, 2024
13 of 16 checks passed
@nickzelei nickzelei deleted the nick/neos-1672-invalid-redis-configurations-causing-worker-to-silently-fail branch December 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants