-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEOS-1672: Fixes worker error shutdown, k8s helm secret revisions #3044
NEOS-1672: Fixes worker error shutdown, k8s helm secret revisions #3044
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@@ -281,14 +282,14 @@ func serve(ctx context.Context) error { | |||
|
|||
mongoconnmanager := connectionmanager.NewConnectionManager(mongoprovider.NewProvider()) | |||
go mongoconnmanager.Reaper(logger) | |||
defer sqlconnmanager.Shutdown(logger) | |||
defer mongoconnmanager.Shutdown(logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
==========================================
- Coverage 35.18% 35.17% -0.02%
==========================================
Files 346 346
Lines 39995 40016 +21
==========================================
Hits 14074 14074
- Misses 24262 24283 +21
Partials 1659 1659 ☔ View full report in Codecov by Sentry. |
rollMe
from the helm annotations. Now that secrets are re-generated on change, if there are no changes the deployment will not roll for no reason