Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1604: fixes dest opt batch dto to handle fallback #2918

Merged

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

linear bot commented Nov 8, 2024

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Nov 8, 2024 0:51am

@nickzelei nickzelei added the enhancement New feature or request label Nov 8, 2024
@nickzelei nickzelei changed the title NEOS-1604: fixes dto to handle fallback NEOS-1604: fixes batch dto to handle fallback Nov 8, 2024
@nickzelei nickzelei changed the title NEOS-1604: fixes batch dto to handle fallback NEOS-1604: fixes dest opt batch dto to handle fallback Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.89%. Comparing base (8250022) to head (d683c7d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
backend/sql/postgresql/models/models.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2918       +/-   ##
===========================================
+ Coverage   13.13%   35.89%   +22.76%     
===========================================
  Files         326      326               
  Lines       37292    37295        +3     
===========================================
+ Hits         4897    13388     +8491     
+ Misses      31663    22357     -9306     
- Partials      732     1550      +818     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit c78b5df into main Nov 8, 2024
11 of 13 checks passed
@nickzelei nickzelei deleted the nick/neos-1604-dest-opts-not-persisting-in-db-properly branch November 8, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants