-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S3 to SQL database types #2911
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 35.86% 35.78% -0.08%
==========================================
Files 323 324 +1
Lines 36973 37073 +100
==========================================
+ Hits 13259 13268 +9
- Misses 22178 22267 +89
- Partials 1536 1538 +2 ☔ View full report in Codecov by Sentry. |
@@ -374,16 +374,23 @@ func (b *sqlSyncBuilder) BuildDestinationConfig(ctx context.Context, params *bb_ | |||
} | |||
} | |||
|
|||
columnTypes := []string{} | |||
columnTypes := []string{} // use map going forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this comment mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to continue using column types and column default properties as lists. I want them to be maps where key is column name because I have to do all this extra work to keep them all in the same order as the columns list
Fixes:
Postgres Broken