Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 to SQL database types #2911

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

alishakawaguchi
Copy link
Contributor

Fixes:

  • bit columns
  • json columns with string as value

Postgres Broken

  • money
  • timetz
  • all arrays

@alishakawaguchi alishakawaguchi self-assigned this Nov 5, 2024
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:25pm

@alishakawaguchi alishakawaguchi added the bug Something isn't working label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 11.00917% with 97 lines in your changes missing coverage. Please review.

Project coverage is 35.78%. Comparing base (8472043) to head (683cc58).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
worker/pkg/benthos/sql/json_processor.go 11.95% 81 Missing ⚠️
internal/benthos/benthos-builder/builders/sql.go 0.00% 10 Missing ⚠️
internal/testutil/utils.go 0.00% 3 Missing ⚠️
worker/pkg/benthos/environment/environment.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
- Coverage   35.86%   35.78%   -0.08%     
==========================================
  Files         323      324       +1     
  Lines       36973    37073     +100     
==========================================
+ Hits        13259    13268       +9     
- Misses      22178    22267      +89     
- Partials     1536     1538       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -374,16 +374,23 @@ func (b *sqlSyncBuilder) BuildDestinationConfig(ctx context.Context, params *bb_
}
}

columnTypes := []string{}
columnTypes := []string{} // use map going forward
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this comment mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to continue using column types and column default properties as lists. I want them to be maps where key is column name because I have to do all this extra work to keep them all in the same order as the columns list

@alishakawaguchi alishakawaguchi merged commit b063df0 into main Nov 5, 2024
8 of 10 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/fix-s3-to-mysql-types branch November 5, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants