Skip to content

Commit

Permalink
change frontend run log env var name (#1188)
Browse files Browse the repository at this point in the history
  • Loading branch information
alishakawaguchi authored Jan 26, 2024
1 parent 8368867 commit d8272a4
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion frontend/apps/web/app/(mgmt)/[account]/runs/[id]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export default function Page({ params }: PageProps): ReactElement {
})}
</div>
{!isSystemAppConfigDataLoading &&
systemAppConfigData?.isKubernetes && (
systemAppConfigData?.enableRunLogs && (
<div>
<JobRunLogs accountId={accountId} runId={id} />
</div>
Expand Down
2 changes: 1 addition & 1 deletion frontend/apps/web/app/api/config/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ export function getSystemAppConfig(): SystemAppConfig {
key: process.env.POSTHOG_KEY,
},
isNeosyncCloud: process.env.NEOSYNC_CLOUD === 'true',
isKubernetes: process.env.KUBERNETES_ENABLED === 'true',
enableRunLogs: process.env.ENABLE_RUN_LOGS === 'true',
};
}
2 changes: 1 addition & 1 deletion frontend/apps/web/app/config/app-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export interface SystemAppConfig {
publicAppBaseUrl: string;
posthog: PosthogConfig;
isNeosyncCloud: boolean;
isKubernetes: boolean;
enableRunLogs: boolean;
}

interface PosthogConfig {
Expand Down
2 changes: 1 addition & 1 deletion frontend/apps/web/charts/app/templates/app-env-vars.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ stringData:

NEOSYNC_CLOUD: {{ .Values.neosyncCloud.enabled | default "false" | quote }}

KUBERNETES_ENABLED: {{ .Values.kubernetes.enabled | default "false" | quote }}
ENABLE_RUN_LOGS: {{ .Values.enableRunLogs | default "false" | quote }}
3 changes: 1 addition & 2 deletions frontend/apps/web/charts/app/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,4 @@ nodeSelector: {}
neosyncCloud:
enabled: false

kubernetes:
enabled: false
enableRunLogs: false

0 comments on commit d8272a4

Please sign in to comment.