Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implimentation of TD3 and SAC algortihms #10

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MickyasTA
Copy link

Hello,

I have implemented the TD3 and SAC algorithms based on your simulator. You can find them, along with the implementation of PPO done by you, in the repository. It would be great if you could review the code and correct any mistakes you find. Currently, both algorithms are running, but since I introduced a replay buffer, the simulation has become slow. To mitigate this, I reduced the number of environments to 50 and set the replay buffer size to 1e4.

It would be greatly appreciated if you could correct any bugs and help build the repository.

Thank you!

@MickyasTA
Copy link
Author

Hello what is the progress on my request ,I see that you modified the repository bit.

@mihirk284
Copy link
Member

Hello,

Thank you for opening this pull request with new algorithms. I missed this PR before I made the update to the codebase and upgrading the simulator. Perhaps I can try in the coming weeks to check the contribution and see if it can be made compatible with the updated version.

On checking the files, I see that there are some other files from your local installation that have been included such as the vscode config file and the PDFs. These may not be immediately relevant in the repository and can be removed. Similarly the configuration options to enable wandb logging by default may also not be needed by end-users by default. Can you please push to address these?

I can check the code related to the new RL algorithms and get back to you in some time.

@MickyasTA
Copy link
Author

Hello,

I wanted to inform you that I have made the necessary modifications based on your feedback and have pushed the updated version. Please take a moment to review it at your convenience to ensure it aligns with your expectations.

with kind regards!
Mickyas Tamiru Asfaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants