Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/terce output #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/terce output #93

wants to merge 3 commits into from

Conversation

EESergey
Copy link

@EESergey EESergey commented Aug 1, 2024

Please do not delete this branch, I will delete it myself after changing the test configuration.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.20%. Comparing base (9254250) to head (f6631a0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #93   +/-   ##
======================================
  Coverage    2.20%   2.20%           
======================================
  Files          11      11           
  Lines         725     725           
======================================
  Hits           16      16           
  Misses        709     709           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not delete this branch

So it is not expected to be merged? Why is it a PR (even opened, not a draft)?

Comment on lines +176 to +189
const c1 = ~~((data.metrics.data_received.values.rate || '0')/1024/1024);
const c2 = ~~((data.metrics.data_sent.values.rate || '0')/1024/1024);
const e3 = (data.metrics.neofs_obj_get_fails && data.metrics.neofs_obj_get_fails.values.rate || '0');
const c3 = ~~((data.metrics.neofs_obj_get_total && data.metrics.neofs_obj_get_total.values.rate || '0') - e3);
const c4 = ~~(data.metrics.neofs_obj_get_duration && data.metrics.neofs_obj_get_duration.values.avg || '0');
const c5 = ~~(data.metrics.neofs_obj_get_duration && data.metrics.neofs_obj_get_duration.values["p(95)"] || '0');
const e6 = (data.metrics.neofs_obj_put_fails && data.metrics.neofs_obj_put_fails.values.rate || '0');
const c6 = ~~((data.metrics.neofs_obj_put_total && data.metrics.neofs_obj_put_total.values.rate || '0') - e6);
const c7 = ~~(data.metrics.neofs_obj_put_duration && data.metrics.neofs_obj_put_duration.values.avg || '0');
const c8 = ~~(data.metrics.neofs_obj_put_duration && data.metrics.neofs_obj_put_duration.values["p(95)"] || '0');
const e9 = (data.metrics.neofs_obj_delete_fails && data.metrics.neofs_obj_delete_fails.values.rate || '0');
const c9 = ~~((data.metrics.neofs_obj_delete_total && data.metrics.neofs_obj_delete_total.values.rate || '0') - e9);
const c10 = ~~(data.metrics.neofs_obj_delete_duration && data.metrics.neofs_obj_delete_duration.values.avg || '0');
const c11 = ~~(data.metrics.neofs_obj_delete_duration && data.metrics.neofs_obj_delete_duration.values["p(95)"] || '0');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these names mean something special?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these names are chosen for convenience, they can be changed to something more meaningful.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if I change the names, the output line will be too long.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output line is already too long, but I do not insist

@EESergey
Copy link
Author

Please do not delete this branch

So it is not expected to be merged? Why is it a PR (even opened, not a draft)?

This is not a draft, this branch is currently used for testing.

@carpawell
Copy link
Member

This is not a draft

I meant that it is an open (not draft) PR with a review request, such PRs are usually expected to be merged, so I am confused.

@roman-khimov roman-khimov added this to the v0.2.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants