src: drop HTTP from the gateway list #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-petrov
reviewed
Mar 19, 2024
src/Home.tsx
Outdated
| <td> | ||
| {node[0]} | ||
| </td> | ||
| <tr> |
There was a problem hiding this comment.
I'm not sure why we have the key here. It doesn't make much sense to me.
There was a problem hiding this comment.
Yes, it's done for React js, otherwise it shows warning in the console
There was a problem hiding this comment.
Huh. Surprising. Especially since I don't see it in the resulting HTML and it's just a table row. OK, fixed.
It's still in get_webstat_metrics.py, but upgrading this script is a bit more complicated, so let's just fix the UI. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
drop-http-gw
branch
from
15bc0f4
to
0395ef7
Compare
mike-petrov
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still in get_webstat_metrics.py, but upgrading this script is a bit more complicated, so let's just fix the UI.