Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: decrease timeout for a contract cache #861

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

evgeniiz321
Copy link
Contributor

closes #859

@evgeniiz321 evgeniiz321 marked this pull request as draft September 25, 2024 00:33
@evgeniiz321 evgeniiz321 marked this pull request as ready for review September 25, 2024 01:55
@evgeniiz321
Copy link
Contributor Author

@roman-khimov do you know what is this NEOFS_CONTRACT_CACHE_TIMEOUT and why are we waiting 30s for it after we set eacl? I decreased it to 2, all tests still pass, not sure if we need it at all.

@roman-khimov
Copy link
Member

Seems like it was based on ACL cache lifetime. But I can't find it now in the node. It also looks a lot like two 15 blocks, maybe related, maybe not. @cthulhu-rider?

@cthulhu-rider
Copy link
Contributor

cache timeout can be configured. With this, defaullt expiration became 1 block. Initially, it was 30s. I bet previous value was set back then

2s is pretty doubtful except for quick blocks <=1s. I see

. If eACLs are updated with --await flag, having cache timeout is questionable. Only if the setting and reading are done from different endpoints

@roman-khimov
Copy link
Member

Test env uses 1s blocks, with --await it should OK to wait for cluster sync in 1-2 blocks, so 2s seems to be safe.

@roman-khimov roman-khimov merged commit 4a60a0a into master Sep 25, 2024
3 of 4 checks passed
@roman-khimov roman-khimov deleted the ezayats/optimize-waiting branch September 25, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EACL tests take too much time
3 participants