Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: sync supported standards with reference #3792

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Jan 20, 2025

Problem

NEP-26 and NEP-27 are not supported.

Solution

Support!

@AnnaShaleva AnnaShaleva added this to the v0.108.0 milestone Jan 20, 2025
@AnnaShaleva AnnaShaleva marked this pull request as ready for review January 21, 2025 10:46
@AnnaShaleva AnnaShaleva marked this pull request as draft January 21, 2025 10:47
@AnnaShaleva
Copy link
Member Author

OK, I need to restore my linter settings.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (16a6a59) to head (3b28749).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   83.14%   83.11%   -0.04%     
==========================================
  Files         335      335              
  Lines       46896    46903       +7     
==========================================
- Hits        38994    38982      -12     
- Misses       6310     6335      +25     
+ Partials     1592     1586       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review January 21, 2025 11:35
pkg/smartcontract/manifest/manifest.go Outdated Show resolved Hide resolved
pkg/core/native/native_nep17.go Outdated Show resolved Hide resolved
A replacement of NEP11Payable and NEP17Payable. The essence is the same,
but these standards have official name since
neo-project/proposals#169.

Signed-off-by: Anna Shaleva <[email protected]>
pkg/core/native/native_nep17.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov merged commit 673b26f into master Jan 21, 2025
33 of 34 checks passed
@roman-khimov roman-khimov deleted the payables branch January 21, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants