Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: move Notary contract out of P2PSigExtensions under Echidna hardfork #3478

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

*: move Notary contract out of P2PSigExtensions under Echidna hardfork #3478

wants to merge 11 commits into from

Commits on Jul 15, 2024

  1. core: introduce Echidna hardfork 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6dee578 View commit details
    Browse the repository at this point in the history

  2. native: fix error message on native cache initialization 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    03c29e0 View commit details
    Browse the repository at this point in the history

  3. interop: improve error message on native cache initialization error 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    99fc248 View commit details
    Browse the repository at this point in the history

  4. native: fix native deploy process 

    It doesn't work for contracts enabled starting from non-nil hardfork:
```
--- FAIL: TestStateroot_GetLatestStateHeight (0.00s)
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	initial gas supply is not set or wrong, setting default value	{"InitialGASSupply": "52000000"}
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	mempool size is not set or wrong, setting default value	{"MemPoolSize": 50000}
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	P2PNotaryRequestPayloadPool size is not set or wrong, setting default value	{"P2PNotaryRequestPayloadPoolSize": 1000}
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	MaxBlockSize is not set or wrong, setting default value	{"MaxBlockSize": 262144}
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	MaxBlockSystemFee is not set or wrong, setting default value	{"MaxBlockSystemFee": 900000000000}
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	MaxTransactionsPerBlock is not set or wrong, using default value	{"MaxTransactionsPerBlock": 512}
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	MaxValidUntilBlockIncrement is not set or wrong, using default value	{"MaxValidUntilBlockIncrement": 86400}
    logger.go:146: 2024-06-04T17:08:35.263+0300	INFO	Hardforks are not set, using default value
    logger.go:146: 2024-06-04T17:08:35.266+0300	INFO	no storage version found! creating genesis block
    chain.go:227:
        	Error Trace:	/home/anna/Documents/GitProjects/nspcc-dev/neo-go/pkg/neotest/chain/chain.go:227
        	            				/home/anna/Documents/GitProjects/nspcc-dev/neo-go/pkg/neotest/chain/chain.go:217
        	            				/home/anna/Documents/GitProjects/nspcc-dev/neo-go/pkg/services/stateroot/service_test.go:319
        	Error:      	Received unexpected error:
        	            	onPersist failed: VM has failed: at instruction 0 (SYSCALL): native contract descriptor cache is not initialized: contract c1e14f19c3e60d0b9244d06dd7ba9b113135ec3b, hardfork Default
        	Test:       	TestStateroot_GetLatestStateHeight
FAIL
coverage: 28.6% of statements

```

It happens because ActiveIn hardfork wasn't taken into account during
`latestHF` computation. This commit also removes the reusage of
`activeIn` variable in deploy procedure, it's misleading and not
necessary startign from #3444.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    cc960d5 View commit details
    Browse the repository at this point in the history

  5. core: fix bug in (bc *Blockchain).isHardforkEnabled 

    This code was never invoked since we had no native contract enabled
starting from some hardfork, Notary is the first one. And luckily, we
have plenty of tests that fail due to this bug.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b2ac71e View commit details
    Browse the repository at this point in the history

  6. core: move Notary contract under Domovoi hardfork 

    Close #3464. Adjust tests, enable all hardforks for RPC server tests
starting from genesis.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4eadc2c View commit details
    Browse the repository at this point in the history

  7. *: get rid of (*Blockchain).GetNotaryContractScriptHash 

    Use `nativehashes.Notary instead of
(*Blockchain).GetNotaryContractScriptHash.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    de83594 View commit details
    Browse the repository at this point in the history

  8. *: move Notary contract out of P2PSigExtensions 

    A part of #3464.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    571a8f5 View commit details
    Browse the repository at this point in the history

  9. core: prevent access to inactive Notary contract 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b735f2e View commit details
    Browse the repository at this point in the history

  10. core: move NotaryAssisted attribute out of P2PSigExtensions 

    Move it under Domovoi hardfork.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1c3644f View commit details
    Browse the repository at this point in the history

  11. core: prevent access to uninitialized NotaryAssisted fee 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8871165 View commit details
    Browse the repository at this point in the history