network: fix TestTryInitStateSync logging data race #3308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed race condition where logging occurs after a test case has been marked as completed, which is causing a panic. Close #3112 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AnnaShaleva
reviewed
Feb 12, 2024
Comment on lines
1083
to
+1084
| s := startTestServer(t) | ||
| defer s.Shutdown() |
There was a problem hiding this comment.
Seems that this problem is the same as #3307 (comment), so we need to refactor all code related to startWithCleanup functionality, because currently it just doesn't work.
|
Closing this PR as not relevant since the logger problem will be fixed in #3307. Ref. #3307 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed race condition where logging occurs after a test case has been marked as completed, which is causing a panic.
It should be after #3307 to prevent the twice-closing problem.
Close #3112