Go 1.22 #183
Merged
Go 1.22 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Khimov <[email protected]>
Fixes #153. Signed-off-by: Roman Khimov <[email protected]>
Don't use deprecated version. Signed-off-by: Roman Khimov <[email protected]>
AnnaShaleva
reviewed
Aug 21, 2024
Signed-off-by: Roman Khimov <[email protected]>
It doesn't seem to be used by anyone even though we still have some records in go.sum for whatever reason. Signed-off-by: Roman Khimov <[email protected]>
github.com/k14s/ytt has moved to github.com/vmware-tanzu/carvel-ytt (0.40.0) and then to carvel.dev/ytt (0.48.0). It has also change the package we used somewhere between 0.40.0 and 0.42.0, now it doesn't provide NewCmd, so we have to do a bit more, but the end result seems to be the same. 0.49.1 is last safe one to upgrade, current 0.50.0 immediately results in the following go.mod changset: --- a/cmd/go.mod +++ b/cmd/go.mod @@ -1,9 +1,11 @@ module github.com/nspcc-dev/neo-bench -go 1.22 +go 1.22.5 + +toolchain go1.23.0 ... (looks like their Go policy is even more fun than ours) and we certainly don't want that. Signed-off-by: Roman Khimov <[email protected]>
This fixes ``` $ golangci-lint --version golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z $ golangci-lint run ./... WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats` ``` The configuration file is updated according to https://golangci-lint.run/usage/configuration/. Signed-off-by: Leonard Lyubich <[email protected]>
According to https://golangci-lint.run/usage/linters/#govet, `check-shadowing` no longer exists. Now it should be ```yaml govet: disable: [shadow] ``` but `shadow` is disabled by default. Thus, whole `govet` section is not needed anymore. ``` $ golangci-lint --version golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z ``` Signed-off-by: Leonard Lyubich <[email protected]>
AnnaShaleva
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.