Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: add original dBFT 2.0 specifications #65

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Feb 15, 2023

An essential part of nspcc-dev/neo-go#2552 investigation.

TODO:

  • Finish model description, documentation and usage notes.
  • Add model schemas.
  • Add model checker configurations.
  • Attach error traces for known deadlocks. Will be done in a separate issue.
  • Add .gitignore for TLC files.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #65 (9866323) into master (31c1bbd) will not change coverage.
The diff coverage is n/a.

❗ Current head 9866323 differs from pull request most recent head 93bb5bb. Consider uploading reports for the commit 93bb5bb to get more accurate results

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          24       24           
  Lines        1296     1296           
=======================================
  Hits          967      967           
  Misses        275      275           
  Partials       54       54           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnnaShaleva AnnaShaleva force-pushed the tla-models branch 7 times, most recently from f80e3db to a100bad Compare February 17, 2023 12:51
formal-models/README.md Outdated Show resolved Hide resolved
formal-models/README.md Outdated Show resolved Hide resolved
formal-models/README.md Outdated Show resolved Hide resolved
formal-models/README.md Outdated Show resolved Hide resolved
formal-models/README.md Outdated Show resolved Hide resolved
formal-models/README.md Show resolved Hide resolved
formal-models/README.md Outdated Show resolved Hide resolved
formal-models/dbft/dbft.tla Show resolved Hide resolved
formal-models/dbft/dbft.tla Show resolved Hide resolved
@roman-khimov
Copy link
Member

In general it's very descriptive and nice, but maybe we need to specifically mention MoreThanFNodesCommittedOrLost in that this logic can't be reliable in detecting lost nodes (even with neo-project/neo#2057), because real nodes can go down at any time.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review February 20, 2023 08:03
@AnnaShaleva AnnaShaleva force-pushed the tla-models branch 2 times, most recently from 2d57c4f to e935a2f Compare February 20, 2023 08:32
@roman-khimov roman-khimov merged commit 64d1eec into master Feb 22, 2023
@roman-khimov roman-khimov deleted the tla-models branch February 22, 2023 10:05
@AnnaShaleva AnnaShaleva added the tla+ Related to the TLA+ algorithm specification label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tla+ Related to the TLA+ algorithm specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants